linux-kernel - Re: [PATCH] serial: 8250: fix error handling in of_platform_serial

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170718072732.GA15573@kroah.com>
Date:   Tue, 18 Jul 2017 09:27:32 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Alexey Khoroshilov <khoroshilov@...ras.ru>
Cc:     Jiri Slaby <jslaby@...e.com>, Arnd Bergmann <arnd@...db.de>,
        linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
        ldv-project@...uxtesting.org
Subject: Re: [PATCH] serial: 8250: fix error handling in
 of_platform_serial_probe()

On Sat, Jul 01, 2017 at 01:49:29AM +0300, Alexey Khoroshilov wrote:
> clk_disable_unprepare(info->clk) is missed in of_platform_serial_probe(),
> while irq_dispose_mapping(port->irq) is missed in of_platform_serial_setup().
> 
> Found by Linux Driver Verification project (linuxtesting.org).
> 
> Signed-off-by: Alexey Khoroshilov <khoroshilov@...ras.ru>
> ---
>  drivers/tty/serial/8250/8250_of.c | 20 +++++++++++++-------
>  1 file changed, 13 insertions(+), 7 deletions(-)

I've had to drop this from my tree due to the obvious build warning it
adds to the system.  Always test-build your patches before sending them
out, it makes maintainers grumpy when you do not do that :(

greg k-h