linux-kernel - Re: [PATCH v3] staging: unisys: visorbus: Constify attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 18 Jul 2017 13:39:50 +0530
From:   Arvind Yadav <arvind.yadav.cs@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     david.kershner@...sys.com, Timothy.Sell@...sys.com,
        bryan.thompson@...sys.com, jon.frisch@...sys.com,
        david.binder@...sys.com, sparmaintainer@...sys.com,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] staging: unisys: visorbus: Constify attribute_group
 structures.

Hi Greg,

On Tuesday 18 July 2017 01:30 PM, Greg KH wrote:
> On Tue, Jul 18, 2017 at 01:24:42PM +0530, Arvind Yadav wrote:
>> attribute_group are not supposed to change at runtime. All functions
>> working with attribute_group provided by <linux/sysfs.h> work
>> with const attribute_group. So mark the non-const structs as const.
>>
>> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
>> ---
>>   drivers/staging/unisys/visorbus/visorbus_main.c | 4 ++--
>>   drivers/staging/unisys/visorbus/visorchipset.c  | 2 +-
>>   2 files changed, 3 insertions(+), 3 deletions(-)
> What changed from the previous patches?  Always include that below the
> --- line as maintainers have no short-term memory at all.
>
> v4?
Sorry, I have missed it. :(
>
> thanks,
>
> greg k-h
~arvind