[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2765965.2brO3pd8z3@positron.chronox.de>
Date: Tue, 18 Jul 2017 10:56:49 +0200
From: Stephan Müller <smueller@...onox.de>
To: Arnd Bergmann <arnd@...db.de>
Cc: "Jason A. Donenfeld" <jason@...c4.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
linux-crypto@...r.kernel.org,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH v12 4/4] LRNG - enable compile
Am Dienstag, 18. Juli 2017, 10:51:41 CEST schrieb Arnd Bergmann:
Hi Arnd,
> On Tue, Jul 18, 2017 at 9:59 AM, Stephan Müller <smueller@...onox.de> wrote:
> > Add LRNG compilation support.
> >
> > diff --git a/drivers/char/Makefile b/drivers/char/Makefile
> > index 53e3372..87e06ec 100644
> > --- a/drivers/char/Makefile
> > +++ b/drivers/char/Makefile
> > @@ -2,7 +2,15 @@
> >
> > # Makefile for the kernel character device drivers.
> > #
> >
> > -obj-y += mem.o random.o
> > +obj-y += mem.o
> > +
> > +ifeq ($(CONFIG_LRNG),y)
> > + obj-$(CONFIG_LRNG) += lrng.o
> > + lrng-y += lrng_base.o lrng_chacha20.o
> > +else
> > + obj-y += random.o
> > +endif
>
> I think you can write the same in a more readable way without the
> intermediate object:
>
> ifdef CONFIG_LRNG
> obj-y += lrng_base.o lrng_chacha20.o
> else
> obj-y += random.o
> endif
Thank you for the hint, it will be included.
>
> Arnd
Ciao
Stephan
Powered by blists - more mailing lists