linux-kernel - Re: [PATCH v2] mfd: Add missing Kconfig dependency for TPS65086

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170718090807.nrqi7okqq2hxiy7s@dell>
Date:   Tue, 18 Jul 2017 10:08:07 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Michal Simek <michal.simek@...inx.com>
Cc:     linux-kernel@...r.kernel.org, monstr@...str.eu
Subject: Re: [PATCH v2] mfd: Add missing Kconfig dependency for TPS65086

On Mon, 17 Jul 2017, Michal Simek wrote:

> MTF_CORE should be enabled when driver is enabled.
> 
> Without this patch you can configure:
> CONFIG_MFD_CORE is not set
> CONFIG_MFD_TPS65086=y
> 
> which ends up with compilation error:
> drivers/mfd/tps65086.o: In function `tps65086_probe':
> drivers/mfd/tps65086.c:110: undefined reference to
> `mfd_add_devices'
> drivers/mfd/tps65086.c:110:(.text+0x128): relocation
> truncated to fit: R_AARCH64_CALL26 against undefined symbol
> `mfd_add_devices'
> 
> Signed-off-by: Michal Simek <michal.simek@...inx.com>
> ---
> 
> Changes in v2:
> - Update commit message based on discussion with Lee Jones
> 
>  drivers/mfd/Kconfig | 1 +
>  1 file changed, 1 insertion(+)

Applied, thanks.

> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 94ad2c1c3d90..f98b5a6d4da8 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -1294,6 +1294,7 @@ config TPS6507X
>  
>  config MFD_TPS65086
>  	tristate "TI TPS65086 Power Management Integrated Chips (PMICs)"
> +	select MFD_CORE
>  	select REGMAP
>  	select REGMAP_IRQ
>  	select REGMAP_I2C

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog