linux-kernel - Re: [PATCH v2 2/5] ACPI / boot: Correct address space of __acpi_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 18 Jul 2017 12:23:15 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     "Rafael J . Wysocki" <rjw@...ysocki.net>,
        Linux PM list <linux-pm@...r.kernel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H . Peter Anvin" <hpa@...or.com>,
        the arch/x86 maintainers <x86@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Hanjun Guo <guohanjun@...wei.com>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>
Subject: Re: [PATCH v2 2/5] ACPI / boot: Correct address space of
 __acpi_map_table()

On Tue, 2017-07-18 at 11:03 +0200, Geert Uytterhoeven wrote:
> Hi Andy,
> 
> On Mon, Jul 17, 2017 at 12:24 PM, Andy Shevchenko
> <andriy.shevchenko@...ux.intel.com> wrote:
> > Sparse complains about wrong address space used in
> > __acpi_map_table()
> > and in __acpi_unmap_table().
> > 
> > arch/x86/kernel/acpi/boot.c:127:29: warning: incorrect type in
> > return expression (different address spaces)
> > arch/x86/kernel/acpi/boot.c:127:29:    expected char *
> > arch/x86/kernel/acpi/boot.c:127:29:    got void [noderef] <asn:2>*
> > arch/x86/kernel/acpi/boot.c:135:23: warning: incorrect type in
> > argument 1 (different address spaces)
> > arch/x86/kernel/acpi/boot.c:135:23:    expected void [noderef]
> > <asn:2>*addr
> > arch/x86/kernel/acpi/boot.c:135:23:    got char *map
> > 
> > Correct address space to be in align of type of returned and passed
> > parameter.
> > 
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > ---
> >  arch/arm64/kernel/acpi.c    | 4 ++--
> 
> Thanks for the update!
> I can confirm this fixes the arm64 build for me.

Thanks to you and thanks to kbuild bot to check for ia64!

I will send v3 soon with fixed this part and extended patch 5.

-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy