linux-kernel - Re: [PATCHv2 0/6] Motorola Droid 4 Audio Support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 18 Jul 2017 11:29:31 +0200
From:   Sebastian Reichel <sebastian.reichel@...labora.co.uk>
To:     Tony Lindgren <tony@...mide.com>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org,
        linux-omap@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCHv2 0/6] Motorola Droid 4 Audio Support

Hi,

On Mon, Jul 17, 2017 at 10:48:33PM -0700, Tony Lindgren wrote:
> * Sebastian Reichel <sebastian.reichel@...labora.co.uk> [170717 07:14]:
> > Hi,
> > 
> > On Mon, Jul 17, 2017 at 03:17:10AM -0700, Tony Lindgren wrote:
> > > * Sebastian Reichel <sebastian.reichel@...labora.co.uk> [170717 03:13]:
> > > > On Mon, Jul 17, 2017 at 02:29:04AM -0700, Tony Lindgren wrote:
> > > > > * Sebastian Reichel <sebastian.reichel@...labora.co.uk> [170712 08:19]:
> > > > > >  * Switch from simple-audio-card to audio-graph-card
> > > > > 
> > > > > Gave this a quick try against v4.13-rc1 with SND_AUDIO_GRAPH_CARD
> > > > > enabled as a loadable module. However loading it oopses for me,
> > > > > see below. Maybe some dependencies are missing?
> > > > 
> > > > It works for me on top of v4.13-rc1 (my kernel is monolithic).
> > > > Looking at the stacktrace it seems to be a bug in audio graph
> > > > card and not in the codec driver.
> > > 
> > > OK I do also have:
> > > 
> > > CONFIG_DEBUG_LOCKDEP=y
> > > CONFIG_DEBUG_ATOMIC_SLEEP=y
> > 
> > I added those and I do not get a stacktrace for anything sound
> > related and audio works. I noticed one issue in dapm routing,
> > that I accidently added. That will be fixed in PATCHv3, but its
> > in untestable path anyways (EXT capture, probably FM radio is
> > connected to EXT).
> 
> Hmm maybe that was not with DEBUG_ATOMIC_SLEEP then?

$ grep DEBUG_ATOMIC_SLEEP .config
CONFIG_DEBUG_ATOMIC_SLEEP=y

> I also verified it does not happen unless your dts patch "ARM:
> dts: omap4-droid4: add soundcard" is applied.

That's what I expected, since the stacktrace started in the
soundcard driver.

> I doubt that having it as loadable module makes any difference
> here as it's the might_sleep() in __mutex_lock_common() producing
> the BUG.

It might make a difference, since it changes the probe order. The
mutex may not even be called on my system.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)