linux-kernel - Re: [PATCH] staging: greybus: loopback: Enclose multiple macro statements in do-while loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170718110433.GK29638@localhost>
Date:   Tue, 18 Jul 2017 13:04:33 +0200
From:   Johan Hovold <johan@...nel.org>
To:     karthik@...hveda.org
Cc:     pure.logic@...us-software.ie, johan@...nel.org, elder@...nel.org,
        gregkh@...uxfoundation.org, greybus-dev@...ts.linaro.org,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        sunil.m@...hveda.org
Subject: Re: [PATCH] staging: greybus: loopback: Enclose multiple macro
 statements in do-while loop

On Tue, Jul 18, 2017 at 04:26:40PM +0530, karthik@...hveda.org wrote:
> From: Karthik Tummala <karthik@...hveda.org>
> 
> Enclosed multiple macro statements in a do - while loop as per kernel
> coding standard, pointed by checkpatch.
								\
>  static DEVICE_ATTR_RO(name##_avg)
>  
> -#define gb_loopback_stats_attrs(field)				\
> -	gb_loopback_ro_stats_attr(field, min, u);		\
> -	gb_loopback_ro_stats_attr(field, max, u);		\
> -	gb_loopback_ro_avg_attr(field)
> +#define gb_loopback_stats_attrs(field)					\
> +do {									\
> +	gb_loopback_ro_stats_attr(field, min, u);			\
> +	gb_loopback_ro_stats_attr(field, max, u);			\
> +	gb_loopback_ro_avg_attr(field);					\
> +} while (0)

You obviously did not even compile-test this before submitting it, which
needless to say, is not ok.

Johan