linux-kernel - Re: [PATCH] drm/i915: Explicit the connector name for DP link training result

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1500377308.1351.5.camel@linux.intel.com>
Date:   Tue, 18 Jul 2017 14:28:28 +0300
From:   Paul Kocialkowski <paul.kocialkowski@...ux.intel.com>
To:     Jani Nikula <jani.nikula@...ux.intel.com>,
        intel-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Cc:     Manasi Navare <manasi.d.navare@...el.com>,
        Daniel Vetter <daniel.vetter@...el.com>,
        David Airlie <airlied@...ux.ie>
Subject: Re: [PATCH] drm/i915: Explicit the connector name for DP link
 training result

Hey,

On Tue, 2017-07-18 at 10:38 +0300, Jani Nikula wrote:
> On Mon, 17 Jul 2017, Paul Kocialkowski <paul.kocialkowski@...ux.intel.
> com> wrote:
> > This adds the connector name when printing a debug message about the
> > DP
> > link training result. It is useful to figure out what connector is
> > failing when multiple DP connectors are used.
> 
> Perhaps more consistent would be using a prefix like this:
> 
> 	DRM_DEBUG_KMS("[CONNECTOR:%d:%s] bla bla blaa\n",
>         	connector->base.base.id, connector->base.name);

You are definitely right, this is what is used all over the place in the
driver, so I should stick to it.

Thanks for the suggestion, I will send out v2 in that direction shortly.

Cheers,

Paul

> > Signed-off-by: Paul Kocialkowski <paul.kocialkowski@...ux.intel.com>
> > ---
> >  drivers/gpu/drm/i915/intel_dp_link_training.c | 10 ++++++----
> >  1 file changed, 6 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/intel_dp_link_training.c
> > b/drivers/gpu/drm/i915/intel_dp_link_training.c
> > index b79c1c0e404c..75a411c94ce5 100644
> > --- a/drivers/gpu/drm/i915/intel_dp_link_training.c
> > +++ b/drivers/gpu/drm/i915/intel_dp_link_training.c
> > @@ -321,13 +321,15 @@ intel_dp_start_link_train(struct intel_dp
> > *intel_dp)
> >  	if (!intel_dp_link_training_channel_equalization(intel_dp))
> >  		goto failure_handling;
> >  
> > -	DRM_DEBUG_KMS("Link Training Passed at Link Rate = %d, Lane
> > count = %d",
> > -		      intel_dp->link_rate, intel_dp->lane_count);
> > +	DRM_DEBUG_KMS("Link Training Passed at Link Rate = %d, Lane
> > count = %d for connector %s",
> > +		      intel_dp->link_rate, intel_dp->lane_count,
> > +		      intel_connector->base.name);
> >  	return;
> >  
> >   failure_handling:
> > -	DRM_DEBUG_KMS("Link Training failed at link rate = %d, lane
> > count = %d",
> > -		      intel_dp->link_rate, intel_dp->lane_count);
> > +	DRM_DEBUG_KMS("Link Training failed at link rate = %d, lane
> > count = %d for connector %s",
> > +		      intel_dp->link_rate, intel_dp->lane_count,
> > +		      intel_connector->base.name);
> >  	if (!intel_dp_get_link_train_fallback_values(intel_dp,
> >  						     intel_dp-
> > >link_rate,
> >  						     intel_dp-
> > >lane_count))
> 
> 
-- 
Paul Kocialkowski <paul.kocialkowski@...ux.intel.com>
Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo, Finland