linux-kernel - Re: [PATCH] usb: dwc2: gadget: On USB RESET reset device address to zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2B3535C5ECE8B5419E3ECBE300772909021B570A8D@US01WEMBX2.internal.synopsys.com>
Date:   Tue, 18 Jul 2017 03:23:58 +0000
From:   John Youn <John.Youn@...opsys.com>
To:     Minas Harutyunyan <Minas.Harutyunyan@...opsys.com>,
        Felipe Balbi <balbi@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb: dwc2: gadget: On USB RESET reset device address to
 zero

On 07/11/2017 03:25 AM, Minas Harutyunyan wrote:
> Reseted DEVADDR field in DCFG to zero on USB RESET.
>
> Device address in DCFG register does not reset to zero,
> which required to pass enumeration, after disconnect and
> reconnect.
>
> Signed-off-by: Minas Harutyunyan <hminas@...opsys.com>
> ---
>  drivers/usb/dwc2/gadget.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
> index 98a4a79e7f6e..c5c0a26a4d66 100644
> --- a/drivers/usb/dwc2/gadget.c
> +++ b/drivers/usb/dwc2/gadget.c
> @@ -3561,6 +3561,9 @@ static irqreturn_t dwc2_hsotg_irq(int irq, void *pw)
>  		/* Report disconnection if it is not already done. */
>  		dwc2_hsotg_disconnect(hsotg);
>
> +		/* Reset device address to zero */
> +		__bic32(hsotg->regs + DCFG, DCFG_DEVADDR_MASK);
> +
>  		if (usb_status & GOTGCTL_BSESVLD && connected)
>  			dwc2_hsotg_core_init_disconnected(hsotg, true);
>  	}
>

Acked-by: John Youn <johnyoun@...opsys.com>


John