linux-kernel - Re: [PATCH resend] checkpatch: Replace __init_refok by __refconst and _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 18 Jul 2017 14:20:16 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Joe Perches <joe@...ches.com>
Cc:     Geert Uytterhoeven <geert+renesas@...der.be>,
        Andy Whitcroft <apw@...onical.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Fabian Frederick <fabf@...net.be>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH resend] checkpatch: Replace __init_refok by __refconst and __refdata

Hi Joe,

On Mon, Jul 17, 2017 at 5:01 PM, Joe Perches <joe@...ches.com> wrote:
> On Mon, 2017-07-17 at 15:42 +0200, Geert Uytterhoeven wrote:
>> As of commit bd721ea73e1f9655 ("treewide: replace obsolete _refok by
>> __ref"), __init_refok no longer exists, so it can be removed.
>> While at it, add the modern variants that were still missing.
>
> Maybe nicer to add some phrase like "Update sparse keywords"
> in the patch title

s/sparse/section/?
Will fix in v2.

>> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
>> ---
>>  scripts/checkpatch.pl | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
>> index 2287a0bca863bf57..b88740bfe9d14e41 100755
>> --- a/scripts/checkpatch.pl
>> +++ b/scripts/checkpatch.pl
>> @@ -343,9 +343,10 @@ our $Sparse      = qr{
>>                       __force|
>>                       __iomem|
>>                       __must_check|
>> -                     __init_refok|
>>                       __kprobes|
>>                       __ref|
>> +                     __refconst|
>> +                     __refdata|
>>                       __rcu|
>>                       __private
>>               }x;
>
> Anyway:
>
> Acked-by: Joe Perches <joe@...ches.com>

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds