linux-kernel - Re: [PATCH v2 3/9] regulator: mt6380: Add support for MT6380

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170718133136.xodadxf2crkcuhze@sirena.org.uk>
Date:   Tue, 18 Jul 2017 14:31:36 +0100
From:   Mark Brown <broonie@...nel.org>
To:     sean.wang@...iatek.com
Cc:     robh+dt@...nel.org, matthias.bgg@...il.com, mark.rutland@....com,
        lgirdwood@...il.com, jamesjj.liao@...iatek.com,
        henryc.chen@...iatek.com, devicetree@...r.kernel.org,
        linux-mediatek@...ts.infradead.org, chen.zhong@...iatek.com,
        chenglin.xu@...iatek.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/9] regulator: mt6380: Add support for MT6380

On Tue, Jul 18, 2017 at 05:49:23PM +0800, sean.wang@...iatek.com wrote:

> +	if (!info->modeset_mask) {
> +		dev_err(&rdev->dev, "regulator %s doesn't support set_mode\n",
> +			info->desc.name);
> +		return -EINVAL;
> +	}

This is mostly fine but the mode operations all have this code - if the
regulator doesn't have modesetting facilities it just shouldn't have
the ops so the core can handle things in a standard fashion.  It'd mean
defining a separate set of operations for those regulators but that's
fine.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)