linux-kernel - Re: [PATCH v2 8/8] staging: fsl-mc: allow the driver compile multi-arch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a0WvNgk5eXQoPpXiLwOS_wB1NdfCyPtiKMys3qqEwHjDw@mail.gmail.com>
Date:   Tue, 18 Jul 2017 16:25:36 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Laurentiu Tudor <laurentiu.tudor@....com>
Cc:     gregkh <gregkh@...uxfoundation.org>,
        Stuart Yoder <stuyoder@...il.com>, devel@...verdev.osuosl.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Marc Zyngier <marc.zyngier@....com>,
        Alexander Graf <agraf@...e.de>,
        Robin Murphy <robin.murphy@....com>,
        Ioana Ciornei <ioana.ciornei@....com>,
        Ruxandra Ioana Radulescu <ruxandra.radulescu@....com>,
        Bharat Bhushan <bharat.bhushan@....com>,
        Catalin Horghidan <catalin.horghidan@....com>,
        Leo Li <leoyang.li@....com>, Roy Pledge <roy.pledge@....com>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2 8/8] staging: fsl-mc: allow the driver compile multi-arch

On Tue, Jul 18, 2017 at 3:37 PM,  <laurentiu.tudor@....com> wrote:

> --- a/drivers/staging/fsl-dpaa2/Kconfig
> +++ b/drivers/staging/fsl-dpaa2/Kconfig
> @@ -4,7 +4,7 @@
>
>  config FSL_DPAA2
>         bool "Freescale DPAA2 devices"
> -       depends on FSL_MC_BUS
> +       depends on FSL_MC_BUS && ARCH_LAYERSCAPE
>         ---help---
>           Build drivers for Freescale DataPath Acceleration
>           Architecture (DPAA2) family of SoCs.

I would probably leave the dependency in there conditionally, like

         depends on ARCH_LAYERSCAPE || COMPILE_TEST

That way, we can build the driver on all architectures with "make allmodconfig"
or "make randconfig", but regular users that disable COMPILE_TEST
won't be bothered by the extra config options unless they have the
right hardware.

       Arnd