linux-kernel - Re: [PATCH] pid: kill pidhash_size in pidhash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20702e4f-10c1-ae91-0c0d-572516b92349@oracle.com>
Date:   Tue, 18 Jul 2017 10:52:33 -0400
From:   Pasha Tatashin <pasha.tatashin@...cle.com>
To:     Kefeng Wang <wangkefeng.wang@...wei.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pid: kill pidhash_size in pidhash_init

Reviewed-by: Pavel Tatashin <Pasha.Tatashin@...cle.com>

On 07/18/2017 10:47 AM, Kefeng Wang wrote:
> After commit 3d375d78593c ("mm: update callers to use HASH_ZERO flag"),
> drop unused pidhash_size in pidhash_init().
> 
> Signed-off-by: Kefeng Wang <wangkefeng.wang@...wei.com>
> ---
>   kernel/pid.c | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/kernel/pid.c b/kernel/pid.c
> index 731c4e5..c69c30d 100644
> --- a/kernel/pid.c
> +++ b/kernel/pid.c
> @@ -575,13 +575,10 @@ struct pid *find_ge_pid(int nr, struct pid_namespace *ns)
>    */
>   void __init pidhash_init(void)
>   {
> -	unsigned int pidhash_size;
> -
>   	pid_hash = alloc_large_system_hash("PID", sizeof(*pid_hash), 0, 18,
>   					   HASH_EARLY | HASH_SMALL | HASH_ZERO,
>   					   &pidhash_shift, NULL,
>   					   0, 4096);
> -	pidhash_size = 1U << pidhash_shift;
>   }
>   
>   void __init pidmap_init(void)
>