linux-kernel - Re: [PATCH] xen/x86: fix cpu hotplug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 18 Jul 2017 11:05:18 -0400
From:   Boris Ostrovsky <boris.ostrovsky@...cle.com>
To:     Juergen Gross <jgross@...e.com>, linux-kernel@...r.kernel.org,
        xen-devel@...ts.xenproject.org, x86@...nel.org
Cc:     hpa@...or.com, tglx@...utronix.de, mingo@...hat.com,
        stable@...r.kernel.org
Subject: Re: [PATCH] xen/x86: fix cpu hotplug

On 07/05/2017 10:05 AM, Juergen Gross wrote:
> Commit dc6416f1d711eb4c1726e845d653235dcaae12e1 ("xen/x86: Call
> cpu_startup_entry(CPUHP_AP_ONLINE_IDLE) from xen_play_dead()")
> introduced an error leading to a stack overflow of the idle task when
> a cpu was brought offline/online many times: by calling
> cpu_startup_entry() instead of returning at the end of xen_play_dead()
> do_idle() would be entered again and again.
>
> Don't use cpu_startup_entry(), but cpuhp_online_idle() instead allowing
> to return from xen_play_dead().
>
> Cc: <stable@...r.kernel.org> # 4.12
> Signed-off-by: Juergen Gross <jgross@...e.com>


Reviewed-by: Boris Ostrovsky <boris.ostrovsky@...cle.com>