linux-kernel - Re: [PATCH] perf probe: Fix build failure for get_target

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 18 Jul 2017 12:45:38 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Michael Ellerman <mpe@...erman.id.au>
Cc:     Ravi Bangoria <ravi.bangoria@...ux.vnet.ibm.com>,
        kjlx@...pleofstupid.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf probe: Fix build failure for get_target_map()

Em Tue, Jul 18, 2017 at 07:19:45PM +1000, Michael Ellerman escreveu:
> Arnaldo Carvalho de Melo <acme@...nel.org> writes:
> 
> > Em Mon, Jul 17, 2017 at 04:02:22PM +0530, Ravi Bangoria escreveu:
> >> Commit 801bc8193463 ("perf probe: Allow placing uprobes in
> >> alternate namespaces.") is causing a build failure on powerpc:
> >> 
> >>   error: incompatible type for argument 2 of 'get_target_map'
> >>   map = get_target_map(pev->target, pev->uprobes);
> >>                                     ^~~
> >> 
> >> Fix it by changing parameters of get_target_map().
> >
> > Thanks, since this hasn't made it to Ingo I'll fold this into the patch
> > where the problem was introduced, adding credits to you, leaving a Link
> > to this message, so that we don't lose bisection in this area on
> > powerpc.
> 
> Thanks.
> 
> I just bisected to this commit too - should have checked the list first! :)

:-)

I just re-ammended this cset to cover the !HAVE_DWARF_SUPPORT build as
well, just re-force-pushed acme/perf/core with this fix.

- Arnaldo