linux-kernel - Re: [PATCH v2] serial: 8250: fix error handling in of_platform_serial

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VcL_L8hOdqQdY=5VWTRHvO=w9Yd9M6stdTmDOnAs4Sbbw@mail.gmail.com>
Date:   Tue, 18 Jul 2017 18:55:42 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Johan Hovold <johan@...nel.org>
Cc:     Alexey Khoroshilov <khoroshilov@...ras.ru>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jslaby@...e.com>, Arnd Bergmann <arnd@...db.de>,
        "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        ldv-project@...uxtesting.org
Subject: Re: [PATCH v2] serial: 8250: fix error handling in of_platform_serial_probe()

On Tue, Jul 18, 2017 at 6:45 PM, Johan Hovold <johan@...nel.org> wrote:
> On Tue, Jul 18, 2017 at 02:32:11PM +0300, Alexey Khoroshilov wrote:
>> clk_disable_unprepare(info->clk) is missed in of_platform_serial_probe(),
>> while irq_dispose_mapping(port->irq) is missed in of_platform_serial_setup().

>> +err_register:
>>       irq_dispose_mapping(port8250.port.irq);
>> +     if (info->clk)
>> +             clk_disable_unprepare(info->clk);
>> +err_setup:
>> +     kfree(info);
>
> Please name also these error labels after what they do rather than after
> from where you jump to them (i.e. as you did above in
> of_platform_serial_setup()).

Actually good point!

-- 
With Best Regards,
Andy Shevchenko