linux-kernel - Re: [PATCH v2 9/9] soc: mediatek: pwrap: fixup warnings from coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1500395194.17774.6.camel@mtksdaap41>
Date:   Wed, 19 Jul 2017 00:26:34 +0800
From:   Yingjoe Chen <yingjoe.chen@...iatek.com>
To:     <sean.wang@...iatek.com>
CC:     <robh+dt@...nel.org>, <matthias.bgg@...il.com>,
        <mark.rutland@....com>, <lgirdwood@...il.com>,
        <broonie@...nel.org>, <jamesjj.liao@...iatek.com>,
        <henryc.chen@...iatek.com>, <devicetree@...r.kernel.org>,
        <linux-mediatek@...ts.infradead.org>, <chenglin.xu@...iatek.com>,
        <chen.zhong@...iatek.com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 9/9] soc: mediatek: pwrap: fixup warnings from coding
 style

[Resend due to bad mail format, sorry about the noise if you got two]


On Tue, 2017-07-18 at 17:49 +0800, sean.wang@...iatek.com wrote:
> From: Sean Wang <sean.wang@...iatek.com>
> 
> fixup those warnings such as lines over 80 words and parenthesis
> alignment which would be complained by checkpatch.pl.
> 
> Signed-off-by: Sean Wang <sean.wang@...iatek.com>
> ---
>  drivers/soc/mediatek/mtk-pmic-wrap.c | 20 +++++++++++++-------
>  1 file changed, 13 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
> index 142f40a..5f1036f 100644
> --- a/drivers/soc/mediatek/mtk-pmic-wrap.c
> +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
> @@ -1057,7 +1057,8 @@ static int pwrap_init_cipher(struct pmic_wrapper *wrp)
>  	/* wait for cipher data ready@...C */
>  	ret = pwrap_wait_for_state(wrp, pwrap_is_pmic_cipher_ready);
>  	if (ret) {
> -		dev_err(wrp->dev, "timeout waiting for cipher data ready@...C\n");
> +		dev_err(wrp->dev,
> +			"timeout waiting for cipher data ready@...C\n");

Sean,

I think the old code is easier to read. When the line is only slightly
over the 80 chars limit, some maintainers will even ask to keep it in
one line to make it easier to read.

So if it is OK with Matthias, I think we should just keep it as is.

Joe.C