linux-kernel - Re: [PATCH resend] Documentation: arm: Replace use of virt_to_phys with __pa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d0d5568e-e70a-5576-fd0f-f01acfe8cfa2@gmail.com>
Date:   Tue, 18 Jul 2017 09:49:17 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Geert Uytterhoeven <geert+renesas@...der.be>,
        Jonathan Corbet <corbet@....net>,
        Russell King <rmk+kernel@...linux.org.uk>
Cc:     Laura Abbott <labbott@...hat.com>, linux-doc@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH resend] Documentation: arm: Replace use of virt_to_phys
 with __pa_symbol

On 07/17/2017 06:39 AM, Geert Uytterhoeven wrote:
> All low-level PM/SMP code using virt_to_phys() should actually use
> __pa_symbol() against kernel symbols.  Update the documentation to move
> away from virt_to_phys().
> 
> Cfr. commit 6996cbb2372189f7 ("ARM: 8641/1: treewide: Replace uses of
> virt_to_phys with __pa_symbol")
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>

Acked-by: Florian Fainelli <f.fainelli@...il.com>

Sorry for not noticing earlier.

> ---
>  Documentation/arm/firmware.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/arm/firmware.txt b/Documentation/arm/firmware.txt
> index da6713adac8acffc..7f175dbb427e631a 100644
> --- a/Documentation/arm/firmware.txt
> +++ b/Documentation/arm/firmware.txt
> @@ -60,7 +60,7 @@ Example of using a firmware operation:
>  
>  	/* some platform code, e.g. SMP initialization */
>  
> -	__raw_writel(virt_to_phys(exynos4_secondary_startup),
> +	__raw_writel(__pa_symbol(exynos4_secondary_startup),
>  		CPU1_BOOT_REG);
>  
>  	/* Call Exynos specific smc call */
> 


-- 
Florian