linux-kernel - Re: [PATCH v4] Bluetooth: btusb: Fix memory leak in play

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201707192230.oRZy26Qi%fengguang.wu@intel.com>
Date:   Wed, 19 Jul 2017 22:53:10 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Jeffy Chen <jeffy.chen@...k-chips.com>
Cc:     kbuild-all@...org, linux-kernel@...r.kernel.org,
        xiyou.wangcong@...il.com, briannorris@...omium.org,
        dianders@...omium.org, Jeffy Chen <jeffy.chen@...k-chips.com>,
        Johan Hedberg <johan.hedberg@...il.com>,
        Marcel Holtmann <marcel@...tmann.org>,
        Gustavo Padovan <gustavo@...ovan.org>,
        linux-bluetooth@...r.kernel.org
Subject: Re: [PATCH v4] Bluetooth: btusb: Fix memory leak in play_deferred

Hi Jeffy,

[auto build test WARNING on bluetooth-next/master]
[also build test WARNING on v4.13-rc1]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Jeffy-Chen/Bluetooth-btusb-Fix-memory-leak-in-play_deferred/20170719-044201
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master
config: arm-exynos_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=arm 

Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings

All warnings (new ones prefixed by >>):

   In file included from drivers/bluetooth/btusb.c:32:0:
   drivers/bluetooth/btusb.c: In function 'btusb_resume':
>> include/net/bluetooth/bluetooth.h:136:26: warning: 'err' may be used uninitialized in this function [-Wmaybe-uninitialized]
    #define BT_ERR(fmt, ...) bt_err(fmt "\n", ##__VA_ARGS__)
                             ^~~~~~
   drivers/bluetooth/btusb.c:3266:6: note: 'err' was declared here
     int err;
         ^~~
--
   In file included from drivers//bluetooth/btusb.c:32:0:
   drivers//bluetooth/btusb.c: In function 'btusb_resume':
>> include/net/bluetooth/bluetooth.h:136:26: warning: 'err' may be used uninitialized in this function [-Wmaybe-uninitialized]
    #define BT_ERR(fmt, ...) bt_err(fmt "\n", ##__VA_ARGS__)
                             ^~~~~~
   drivers//bluetooth/btusb.c:3266:6: note: 'err' was declared here
     int err;
         ^~~

vim +/err +136 include/net/bluetooth/bluetooth.h

3ed7003e7 Joe Perches    2012-02-16  133  
3ed7003e7 Joe Perches    2012-02-16  134  #define BT_INFO(fmt, ...)	bt_info(fmt "\n", ##__VA_ARGS__)
594b31ea7 Frederic Danis 2015-09-23  135  #define BT_WARN(fmt, ...)	bt_warn(fmt "\n", ##__VA_ARGS__)
3ed7003e7 Joe Perches    2012-02-16 @136  #define BT_ERR(fmt, ...)	bt_err(fmt "\n", ##__VA_ARGS__)
3ed7003e7 Joe Perches    2012-02-16  137  #define BT_DBG(fmt, ...)	pr_debug(fmt "\n", ##__VA_ARGS__)
^1da177e4 Linus Torvalds 2005-04-16  138  

:::::: The code at line 136 was first introduced by commit
:::::: 3ed7003e724a04482e0ef1e794eece8c1c177b37 Bluetooth: Add logging functions bt_info and bt_err

:::::: TO: Joe Perches <joe@...ches.com>
:::::: CC: Johan Hedberg <johan.hedberg@...el.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (27439 bytes)