linux-kernel - Re: [PATCH 1/4] ARM: dts: keystone-k2g: Add PMMC node to support TI-SCI protocol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d2cc6c0e-9f78-aac5-f20e-3695b36ec3a3@ti.com>
Date:   Wed, 19 Jul 2017 10:25:41 -0500
From:   "Andrew F. Davis" <afd@...com>
To:     Suman Anna <s-anna@...com>, Santosh Shilimkar <ssantosh@...nel.org>
CC:     Rob Herring <robh+dt@...nel.org>,
        Franklin S Cooper Jr <fcooper@...com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Nishanth Menon <nm@...com>, Tero Kristo <t-kristo@...com>,
        Dave Gerlach <d-gerlach@...com>
Subject: Re: [PATCH 1/4] ARM: dts: keystone-k2g: Add PMMC node to support
 TI-SCI protocol

On 07/18/2017 06:50 PM, Suman Anna wrote:
> On 07/18/2017 10:00 AM, Andrew F. Davis wrote:
>> On 07/17/2017 10:28 PM, Suman Anna wrote:
>>> From: Nishanth Menon <nm@...com>
>>>
>>> Texas Instrument's System Control Interface (TI-SCI) Message Protocol
>>> is implemented in Keystone 2 generation 66AK2G SoC with the PMMC entity.
>>>
>>> Add the ti-sci node representing this 66AK2G PMMC module.
>>>
>>> Signed-off-by: Nishanth Menon <nm@...com>
>>> [s-anna@...com: add unit address to DT node]
>>> Signed-off-by: Suman Anna <s-anna@...com>
>>> ---
>>>  arch/arm/boot/dts/keystone-k2g.dtsi | 14 ++++++++++++++
>>>  1 file changed, 14 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/keystone-k2g.dtsi b/arch/arm/boot/dts/keystone-k2g.dtsi
>>> index a789f75a1ed5..7f0f4180b373 100644
>>> --- a/arch/arm/boot/dts/keystone-k2g.dtsi
>>> +++ b/arch/arm/boot/dts/keystone-k2g.dtsi
>>> @@ -139,5 +139,19 @@
>>>  			interrupts = <GIC_SPI 324 IRQ_TYPE_LEVEL_HIGH>,
>>>  				     <GIC_SPI 327 IRQ_TYPE_LEVEL_HIGH>;
>>>  		};
>>> +
>>> +		pmmc: pmmc@...21c00 {
>>> +			compatible = "ti,k2g-sci";
>>> +			/*
>>> +			 * In case of rare platforms that does not use k2g as
>>> +			 * system master, use /delete-property/
>>> +			 */
>>
>> This comment seems mis-worded, I believe this was meant to say "for
>> platforms that do not use the *PMMC* as the system master".
> 
> The comment is for the system-reboot-controller property, and is meant
> to say that this property is to be deleted from this node if there is an
> external entity on the board other than the K2G SoC that is responsible
> for triggering a reboot.
> 

I see, that makes more sense, thanks for the clarification.

Andrew

> regards
> Suman
> 
>>
>> Andrew
>>
>>> +			ti,system-reboot-controller;
>>> +			mbox-names = "rx", "tx";
>>> +			mboxes= <&msgmgr 5 2>,
>>> +				<&msgmgr 0 0>;
>>> +			reg-names = "debug_messages";
>>> +			reg = <0x02921c00 0x400>;
>>> +		};
>>>  	};
>>>  };
>>>
>