linux-kernel - Re: [PATCH] ARM: Convert to using %pOF instead of full

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_JsqK1Y3xhZwNxme934UF_t=6ZdSyqBtrMmceUC798ftL+mQ@mail.gmail.com>
Date:   Wed, 19 Jul 2017 10:35:20 -0500
From:   Rob Herring <robh@...nel.org>
To:     Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
Cc:     "arm@...nel.org" <arm@...nel.org>, Andrew Lunn <andrew@...n.ch>,
        Heiko Stuebner <heiko@...ech.de>,
        Tony Lindgren <tony@...mide.com>,
        "linux-samsung-soc@...r.kernel.org" 
        <linux-samsung-soc@...r.kernel.org>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
        Magnus Damm <magnus.damm@...il.com>,
        Russell King <linux@...linux.org.uk>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Javier Martinez Canillas <javier@....samsung.com>,
        Kukjin Kim <kgene@...nel.org>,
        Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Jason Cooper <jason@...edaemon.net>,
        Simon Horman <horms@...ge.net.au>,
        Gregory Clement <gregory.clement@...e-electrons.com>,
        linux-omap <linux-omap@...r.kernel.org>,
        Sascha Hauer <kernel@...gutronix.de>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        Paul Walmsley <paul@...an.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "open list:MEDIA DRIVERS FOR RENESAS - FCP" 
        <linux-renesas-soc@...r.kernel.org>,
        Benoît Cousson <bcousson@...libre.com>,
        Fabio Estevam <fabio.estevam@....com>,
        Shawn Guo <shawnguo@...nel.org>
Subject: Re: [PATCH] ARM: Convert to using %pOF instead of full_name

On Wed, Jul 19, 2017 at 1:22 AM, Uwe Kleine-König
<u.kleine-koenig@...gutronix.de> wrote:
> On Tue, Jul 18, 2017 at 04:42:41PM -0500, Rob Herring wrote:
>> Now that we have a custom printf format specifier, convert users of
>> full_name to use %pOF instead. This is preparation to remove storing
>
> Oh nice. If the commit adding %pOF is already set in stone, i'd suggest
> to mention the commit id here in the commit log.

It is in 4.13, but I'm not really eager to update all 60 patches and
I'd prefer consistency in the commit msg as quite a few have already
been applied.

>> of the full path string for each node.

[...]

>> @@ -103,8 +103,8 @@ void __init arm_dt_init_cpu_maps(void)
>>                */
>>               cell = of_get_property(cpu, "reg", &prop_bytes);
>>               if (!cell || prop_bytes < sizeof(*cell)) {
>> -                     pr_debug(" * %s missing reg property\n",
>> -                                  cpu->full_name);
>> +                     pr_debug(" * %pOF missing reg property\n",
>> +                                  cpu);
>
> You could join lines here and in the next hunk. And there are two more
> further down.

Okay. I did that generally, but missed a few.

Rob