linux-kernel - Re: [PATCH 002/102] ARM: socfpga: explicitly request exclusive reset control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170719161237.GA22403@tyrael.ni.corp.natinst.com>
Date:   Wed, 19 Jul 2017 09:12:37 -0700
From:   Moritz Fischer <mdf@...nel.org>
To:     Philipp Zabel <p.zabel@...gutronix.de>
Cc:     linux-kernel@...r.kernel.org, Alan Tull <atull@...nel.org>,
        Moritz Fischer <moritz.fischer@...us.com>,
        linux-fpga@...r.kernel.org
Subject: Re: [PATCH 002/102] ARM: socfpga: explicitly request exclusive reset
 control

On Wed, Jul 19, 2017 at 05:25:06PM +0200, Philipp Zabel wrote:
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior. Convert all drivers requesting exclusive resets to the
> explicit API call so the temporary transition helpers can be removed.
> 
> No functional changes.
> 
> Cc: Alan Tull <atull@...nel.org>
> Cc: Moritz Fischer <moritz.fischer@...us.com>
> Cc: linux-fpga@...r.kernel.org
> Signed-off-by: Philipp Zabel <p.zabel@...gutronix.de>
Acked-By: Moritz Fischer <mdf@...nel.org>
> ---
>  drivers/fpga/altera-hps2fpga.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/fpga/altera-hps2fpga.c b/drivers/fpga/altera-hps2fpga.c
> index 3066b805f2d07..a18ff430c9af1 100644
> --- a/drivers/fpga/altera-hps2fpga.c
> +++ b/drivers/fpga/altera-hps2fpga.c
> @@ -145,7 +145,8 @@ static int alt_fpga_bridge_probe(struct platform_device *pdev)
>  	of_id = of_match_device(altera_fpga_of_match, dev);
>  	priv = (struct altera_hps2fpga_data *)of_id->data;
>  
> -	priv->bridge_reset = of_reset_control_get_by_index(dev->of_node, 0);
> +	priv->bridge_reset = of_reset_control_get_exclusive_by_index(dev->of_node,
> +								     0);
>  	if (IS_ERR(priv->bridge_reset)) {
>  		dev_err(dev, "Could not get %s reset control\n", priv->name);
>  		return PTR_ERR(priv->bridge_reset);
> -- 
> 2.11.0
> 

Thanks,

Moritz

Download attachment "signature.asc" of type "application/pgp-signature" (456 bytes)