linux-kernel - Re: [PATCH 095/102] watchdog: rt2880: explicitly request exclusive reset control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170719173606.GC11439@roeck-us.net>
Date:   Wed, 19 Jul 2017 10:36:06 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Philipp Zabel <p.zabel@...gutronix.de>
Cc:     linux-kernel@...r.kernel.org, Wim Van Sebroeck <wim@...ana.be>,
        linux-watchdog@...r.kernel.org
Subject: Re: [PATCH 095/102] watchdog: rt2880: explicitly request exclusive
 reset control

On Wed, Jul 19, 2017 at 05:26:39PM +0200, Philipp Zabel wrote:
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior. Convert all drivers requesting exclusive resets to the
> explicit API call so the temporary transition helpers can be removed.
> 
> No functional changes.
> 
> Cc: Wim Van Sebroeck <wim@...ana.be>
> Cc: Guenter Roeck <linux@...ck-us.net>
> Cc: linux-watchdog@...r.kernel.org
> Signed-off-by: Philipp Zabel <p.zabel@...gutronix.de>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>  drivers/watchdog/rt2880_wdt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/rt2880_wdt.c b/drivers/watchdog/rt2880_wdt.c
> index 05524baf7dccb..0d481a63cab14 100644
> --- a/drivers/watchdog/rt2880_wdt.c
> +++ b/drivers/watchdog/rt2880_wdt.c
> @@ -152,7 +152,7 @@ static int rt288x_wdt_probe(struct platform_device *pdev)
>  	if (IS_ERR(rt288x_wdt_clk))
>  		return PTR_ERR(rt288x_wdt_clk);
>  
> -	rt288x_wdt_reset = devm_reset_control_get(&pdev->dev, NULL);
> +	rt288x_wdt_reset = devm_reset_control_get_exclusive(&pdev->dev, NULL);
>  	if (!IS_ERR(rt288x_wdt_reset))
>  		reset_control_deassert(rt288x_wdt_reset);
>  
> -- 
> 2.11.0
>