linux-kernel - Re: [PATCH] ibm_rtl: remove unnecessary static in ibm_rtl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VdrNGkCSEBU_m8wrWAZb2PRACxiQFEBovq1+2rnmfTFFw@mail.gmail.com>
Date:   Wed, 19 Jul 2017 21:12:00 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc:     Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ibm_rtl: remove unnecessary static in ibm_rtl_write()

On Wed, Jul 19, 2017 at 1:01 AM, Gustavo A. R. Silva
<gustavo@...eddedor.com> wrote:
> Remove unnecessary static on local variable cmd_port_val. Such variable
> is initialized before being used, on every execution path throughout
> the function. The static has no benefit and, removing it reduces the
> object file size.
>
> This issue was detected using Coccinelle and the following semantic patch:
> https://github.com/GustavoARSilva/coccinelle/blob/master/static/static_unused.cocci
>
> In the following log you can see a difference in the object file size.
> This log is the output of the size command, before and after the code
> change:
>
> before:
>    text    data     bss     dec     hex filename
>    3932 3440     512    7884    1ecc drivers/platform/x86/ibm_rtl.o
>
> after:
>    text    data     bss     dec     hex filename
>    3887    3384     448    7719    1e27 drivers/platform/x86/ibm_rtl.o
>

Pushed to testing, thanks,

> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> ---
>  drivers/platform/x86/ibm_rtl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/ibm_rtl.c b/drivers/platform/x86/ibm_rtl.c
> index c62e5e1..610ac83 100644
> --- a/drivers/platform/x86/ibm_rtl.c
> +++ b/drivers/platform/x86/ibm_rtl.c
> @@ -103,7 +103,7 @@ static void rtl_port_unmap(void __iomem *addr)
>  static int ibm_rtl_write(u8 value)
>  {
>         int ret = 0, count = 0;
> -       static u32 cmd_port_val;
> +       u32 cmd_port_val;
>
>         RTL_DEBUG("%s(%d)\n", __func__, value);
>
> --
> 2.5.0
>



-- 
With Best Regards,
Andy Shevchenko