linux-kernel - Re: [PATCH] fpga: Convert to using %pOF instead of full

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170719044221.GA1581@tyrael.ni.corp.natinst.com>
Date:   Tue, 18 Jul 2017 21:42:21 -0700
From:   Moritz Fischer <mdf@...nel.org>
To:     Rob Herring <robh@...nel.org>
Cc:     Alan Tull <atull@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        Moritz Fischer <moritz.fischer@...us.com>,
        linux-fpga@...r.kernel.org
Subject: Re: [PATCH] fpga: Convert to using %pOF instead of full_name

On Tue, Jul 18, 2017 at 04:43:02PM -0500, Rob Herring wrote:
> Now that we have a custom printf format specifier, convert users of
> full_name to use %pOF instead. This is preparation to remove storing
> of the full path string for each node.
> 
> Signed-off-by: Rob Herring <robh@...nel.org>
> Cc: Alan Tull <atull@...nel.org>
> Cc: Moritz Fischer <moritz.fischer@...us.com>
> Cc: linux-fpga@...r.kernel.org
Acked-by: Moritz Fischer <mdf@...nel.org>
> ---
>  drivers/fpga/fpga-region.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/fpga/fpga-region.c b/drivers/fpga/fpga-region.c
> index 3b6b2f4182a1..d9ab7c75b14f 100644
> --- a/drivers/fpga/fpga-region.c
> +++ b/drivers/fpga/fpga-region.c
> @@ -319,8 +319,8 @@ static int child_regions_with_firmware(struct device_node *overlay)
>  	of_node_put(child_region);
> 
>  	if (ret)
> -		pr_err("firmware-name not allowed in child FPGA region: %s",
> -		       child_region->full_name);
> +		pr_err("firmware-name not allowed in child FPGA region: %pOF",
> +		       child_region);
> 
>  	return ret;
>  }
> --
> 2.11.0
>