linux-kernel - RE: [PATCH v1 4/6] vmbus: Switch to use new generic UUID API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MWHPR21MB04791ED8A0F0F935176AE9B3CAA60@MWHPR21MB0479.namprd21.prod.outlook.com>
Date:   Wed, 19 Jul 2017 20:18:24 +0000
From:   Haiyang Zhang <haiyangz@...rosoft.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
        "devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
        "sparmaintainer@...sys.com" <sparmaintainer@...sys.com>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "linux-watchdog@...r.kernel.org" <linux-watchdog@...r.kernel.org>,
        "linux-efi@...r.kernel.org" <linux-efi@...r.kernel.org>,
        Christoph Hellwig <hch@....de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Lukas Wunner <lukas@...ner.de>
CC:     KY Srinivasan <kys@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>
Subject: RE: [PATCH v1 4/6] vmbus: Switch to use new generic UUID API



> -----Original Message-----
> From: Andy Shevchenko [mailto:andriy.shevchenko@...ux.intel.com]
> Sent: Wednesday, July 19, 2017 2:29 PM
> To: linux-acpi@...r.kernel.org; devel@...uxdriverproject.org;
> sparmaintainer@...sys.com; devel@...verdev.osuosl.org; linux-
> wireless@...r.kernel.org; linux-watchdog@...r.kernel.org; linux-
> efi@...r.kernel.org; Christoph Hellwig <hch@....de>; linux-
> kernel@...r.kernel.org; Lukas Wunner <lukas@...ner.de>
> Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>; KY Srinivasan
> <kys@...rosoft.com>; Haiyang Zhang <haiyangz@...rosoft.com>; Stephen
> Hemminger <sthemmin@...rosoft.com>
> Subject: [PATCH v1 4/6] vmbus: Switch to use new generic UUID API
> 


> @@ -118,8 +116,8 @@ enum hv_fcopy_op {
> 
>  struct hv_fcopy_hdr {
>  	__u32 operation;
> -	uuid_le service_id0; /* currently unused */
> -	uuid_le service_id1; /* currently unused */
> +	__u8 service_id0[16]; /* currently unused */
> +	__u8 service_id1[16]; /* currently unused */
>  } __attribute__((packed));

Even user space may not have all guid_t operations, could you still
put guid_t here for consistency? This file is also used by our kernel
mode code.

Thanks,
- Haiyang