linux-kernel - [v2,1/2] RDMA/uverbs: Fix the check for port number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1500043291-19768-2-git-send-email-mustafa.ismail@intel.com>
Date:   Wed, 19 Jul 2017 23:34:13 +0300
From:   "Ismail, Mustafa" <mustafa.ismail@...el.com>
To:     linux-rdma@...r.kernel.org, dledford@...hat.com
Cc:     swise@...ngridcomputing.com, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org, e1000-rdma@...ts.sourceforge.net,
        shiraz.saleem@...el.com, Marcel Apfelbaum <marcel@...hat.com>
Subject: [v2,1/2] RDMA/uverbs: Fix the check for port number

The port number is only valid if IB_QP_PORT is set in the mask.
So only check port number if it is valid to prevent modify_qp from
failing due to an invalid port number.

Fixes: 5ecce4c9b17b("Check port number supplied by user verbs cmds")
Cc: <stable@...r.kernel.org> # v2.6.14+
Reviewed-by: Steve Wise <swise@...ngridcomputing.com>
Signed-off-by: Mustafa Ismail <mustafa.ismail@...el.com>
Tested-by: Mike Marciniszyn <mike.marciniszyn@...el.com>
---
 drivers/infiniband/core/uverbs_cmd.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/infiniband/core/uverbs_cmd.c b/drivers/infiniband/core/uverbs_cmd.c
index 8ba9bfb..19de068 100644
--- a/drivers/infiniband/core/uverbs_cmd.c
+++ b/drivers/infiniband/core/uverbs_cmd.c
@@ -1935,7 +1935,8 @@ static int modify_qp(struct ib_uverbs_file *file,
 		goto out;
 	}
 
-	if (!rdma_is_port_valid(qp->device, cmd->base.port_num)) {
+	if ((cmd->base.attr_mask & IB_QP_PORT) &&
+	    !rdma_is_port_valid(qp->device, cmd->base.port_num)) {

FWIW,

Reviewed-by: Yuval Shaia <yuval.shaia@...cle.com>

and/or

Tested-by: Yuval Shaia <yuval.shaia@...cle.com>


 		ret = -EINVAL;
 		goto release_qp;
 	}