[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20170719064121.13948-1-fenglinw@codeaurora.org>
Date: Wed, 19 Jul 2017 14:39:55 +0800
From: fenglinw@...eaurora.org
To: linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
bjorn.andersson@...aro.org,
Linus Walleij <linus.walleij@...aro.org>,
linux-gpio@...r.kernel.org
Cc: collinsd@...eaurora.org, aghayal@...eaurora.org,
wruan@...eaurora.org, kgunda@...eaurora.org,
Fenglin Wu <fenglinw@...eaurora.org>
Subject: [PATCH V1] pinctrl: qcom: spmi-gpio: Correct power_source range check
From: Fenglin Wu <fenglinw@...eaurora.org>
Power source selection in DIG_VIN_CTL is indexed from 0, in the range
check it shouldn't be equal to the total number of power sources.
Signed-off-by: Fenglin Wu <fenglinw@...eaurora.org>
---
drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
index 664b641..8b77c04 100644
--- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
+++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
@@ -375,7 +375,7 @@ static int pmic_gpio_config_set(struct pinctrl_dev *pctldev, unsigned int pin,
pad->is_enabled = false;
break;
case PIN_CONFIG_POWER_SOURCE:
- if (arg > pad->num_sources)
+ if (arg >= pad->num_sources)
return -EINVAL;
pad->power_source = arg;
break;
--
Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.
Powered by blists - more mailing lists