linux-kernel - [PATCH 7/8] s390: tape_core: constify attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1500448157-24668-8-git-send-email-arvind.yadav.cs@gmail.com>
Date:   Wed, 19 Jul 2017 12:39:16 +0530
From:   Arvind Yadav <arvind.yadav.cs@...il.com>
To:     schwidefsky@...ibm.com, freude@...ibm.com,
        heiko.carstens@...ibm.com, linux-s390@...r.kernel.org,
        sth@...ux.vnet.ibm.com, hoeppner@...ux.vnet.ibm.com,
        sebott@...ux.vnet.ibm.com, oberpar@...ux.vnet.ibm.com,
        wi@...ux.vnet.ibm.com, ubraun@...ux.vnet.ibm.com,
        jwi@...ux.vnet.ibm.com
Cc:     linux-kernel@...r.kernel.org
Subject: [PATCH 7/8] s390: tape_core: constify attribute_group structures.

attribute_group are not supposed to change at runtime. All functions
working with attribute_group provided by <linux/sysfs.h> work
with const attribute_group. So mark the non-const structs as const.

File size before:
   text	   data	    bss	    dec	    hex	filename
  11511	    656	     16	  12183	   2f97	drivers/s390/char/tape_core.o

File size After adding 'const':
   text	   data	    bss	    dec	    hex	filename
  11575	    592	     16	  12183	   2f97	drivers/s390/char/tape_core.o

Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
---
 drivers/s390/char/tape_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/s390/char/tape_core.c b/drivers/s390/char/tape_core.c
index 3c379da..9dd4534 100644
--- a/drivers/s390/char/tape_core.c
+++ b/drivers/s390/char/tape_core.c
@@ -175,7 +175,7 @@ static int devid_to_int(struct ccw_dev_id *dev_id)
 	NULL
 };
 
-static struct attribute_group tape_attr_group = {
+static const struct attribute_group tape_attr_group = {
 	.attrs = tape_attrs,
 };
 
-- 
1.9.1