linux-kernel - Re: [RFC PATCH 1/2] drivers: dma-coherent: Introduce interface for default DMA pool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170719072001.GA20840@lst.de>
Date:   Wed, 19 Jul 2017 09:20:02 +0200
From:   Christoph Hellwig <hch@....de>
To:     Vladimir Murzin <vladimir.murzin@....com>
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux@...linux.org.uk, sza@....hu, arnd@...db.de,
        gregkh@...uxfoundation.org, akpm@...ux-foundation.org,
        alexandre.torgue@...com, robin.murphy@....com, kbuild-all@...org,
        benjamin.gaignard@...aro.org, hch@....de, m.szyprowski@...sung.com,
        vitaly_kuzmichev@...tor.com, george_davis@...tor.com
Subject: Re: [RFC PATCH 1/2] drivers: dma-coherent: Introduce interface for
        default DMA pool

On Mon, Jul 17, 2017 at 09:58:04AM +0100, Vladimir Murzin wrote:
> Christoph noticed [1] that default DMA pool in current form overload
> the DMA coherent infrastructure. In reply, Robin suggested to split
> the per-device vs. global pool interfaces, so allocation/release from
> default DMA pool is driven by dma ops implementation.
> 
> This patch implements Robin's idea and provide interface to
> allocate/release/mmap the default/global DMA pool.
> 
> [1] https://lkml.org/lkml/2017/7/7/370
> [2] https://lkml.org/lkml/2017/7/7/431
> 
> Suggested-by: Robin Murphy <robin.murphy@....com>
> Signed-off-by: Vladimir Murzin <vladimir.murzin@....com>

This looks good to me.  I'd just rename the existin *_from_coherent
routines to *_from_dev_coherent.