linux-kernel - Re: [PATCH 0/2] use correct values for startup time bits for AXP22X/AXP8XX PEKs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 19 Jul 2017 15:24:25 +0800
From:   Chen-Yu Tsai <wens@...e.org>
To:     Lee Jones <lee.jones@...aro.org>,
        Quentin Schulz <quentin.schulz@...e-electrons.com>
Cc:     Chen-Yu Tsai <wens@...e.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Hans de Goede <hdegoede@...hat.com>,
        "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>,
        Maxime Ripard <maxime.ripard@...e-electrons.com>
Subject: Re: [PATCH 0/2] use correct values for startup time bits for
 AXP22X/AXP8XX PEKs

On Tue, Jul 18, 2017 at 5:53 PM, Lee Jones <lee.jones@...aro.org> wrote:
> On Tue, 18 Jul 2017, Chen-Yu Tsai wrote:
>
>> On Tue, Jul 18, 2017 at 3:25 PM, Quentin Schulz
>> <quentin.schulz@...e-electrons.com> wrote:
>> > Hi Lee,
>> >
>> > On 18/07/2017 09:18, Lee Jones wrote:
>> >> On Mon, 17 Jul 2017, Quentin Schulz wrote:
>> >>
>> >>> Hi all,
>> >>>
>> >>> On 17/07/2017 11:53, Quentin Schulz wrote:
>> >>>> According to their datasheets, the AXP221, AXP223, AXP288, AXP803,
>> >>>> AXP809 and AXP813 PEK have different values for startup time bits from
>> >>>> the AXP20X PEK (which are currently used for all the aforementioned PMICs).
>> >>>>
>> >>>> This patch series adds support for platform_device_id to axp20x-pek driver
>> >>>> to support different startup time bits depending on PMIC's variant and set
>> >>>> the correct platform_device_id in the mfd.
>> >>>>
>> >>>> This has been tested on AXP813. To perform the test, modify the value of
>> >>>> startup and/or shutdown of the pek in sysfs. Press the button soldered to
>> >>>> PEK input of the AXP the amount of time you set in sysfs. The PMIC shuts
>> >>>> down the board without needing to unplug any power supply. Press PEK button
>> >>>> the amount of time you set in sysfs for startup and the PMIC will start the
>> >>>> board. Note that the time bits are obivoulsy hardware reset to their
>> >>>> default when you unplug all power supplies from the board.
>> >>>>
>> >>>
>> >>> I forgot to add that it depends on this patch series (particularly the
>> >>> third patch (3/6) "mfd: axp20x: Add support for AXP813 PMIC") from
>> >>> Chen-Yu:
>> >>> https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1428284.html
>> >>
>> >> So you are going to re-send?
>> >>
>> >
>> > You put your acked-by just yesterday on this patch. Do I need to resend
>> > it anyway?
>> >
>> > The link I provided seems to be really slow/not working today, so I give
>> > you another one for reference: https://patchwork.kernel.org/patch/9803439/
>>
>> Or rather, would you like me to merge the AXP813 changes into my next
>> version, and you resend the rest for faster separate inclusion?
>
> What I'd really like is for one of you to collect up the patches which
> depend on each other (in the correct order of course), along with the
> Acks you've obtained and send as a single set.  That way, I am less
> likely to mess up the ordering when applying.

I'll include the mfd patch in my axp813 series.

Quentin, please send only the input driver for v2.

ChenYu

>
>> >>>> Quentin Schulz (2):
>> >>>>   Input: axp20x-pek: add support for AXP221 PEK
>> >>>>   mfd: axp20x: use correct platform device id for many PEK
>> >>>>
>> >>>>  drivers/input/misc/axp20x-pek.c | 62 ++++++++++++++++++++++++++++++++++-------
>> >>>>  drivers/mfd/axp20x.c            | 12 ++++----
>> >>>>  2 files changed, 58 insertions(+), 16 deletions(-)
>> >>>>
>> >>>
>> >>
>> >
>
> --
> Lee Jones
> Linaro STMicroelectronics Landing Team Lead
> Linaro.org │ Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog