linux-kernel - Re: [PATCH] hwmon: i5k_amb: constify pci_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <96bb044d-469a-8ea2-8213-992493a06b43@roeck-us.net>
Date:   Tue, 18 Jul 2017 18:49:42 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>, jdelvare@...e.com
Cc:     linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hwmon: i5k_amb: constify pci_device_id.

On 07/17/2017 09:25 AM, Arvind Yadav wrote:
> pci_device_id are not supposed to change at runtime. All functions
> working with pci_device_id provided by <linux/pci.h> work with
> const pci_device_id. So mark the non-const structs as const.
> 
> File size before:
>     text	   data	    bss	    dec	    hex	filename
>     3562	    320	      8	   3890	    f32	drivers/hwmon/i5k_amb.o
> 
> File size After adding 'const':
>     text	   data	    bss	    dec	    hex	filename
>     3658	    224	      8	   3890	    f32	drivers/hwmon/i5k_amb.o
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>

Applied to hwmon-next.

Thanks,
Guenter

> ---
>   drivers/hwmon/i5k_amb.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/i5k_amb.c b/drivers/hwmon/i5k_amb.c
> index a5a9f45..9397d2f 100644
> --- a/drivers/hwmon/i5k_amb.c
> +++ b/drivers/hwmon/i5k_amb.c
> @@ -495,7 +495,7 @@ static struct {
>   };
>   
>   #ifdef MODULE
> -static struct pci_device_id i5k_amb_ids[] = {
> +static const struct pci_device_id i5k_amb_ids[] = {
>   	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_5000_ERR) },
>   	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_5400_ERR) },
>   	{ 0, }
>