linux-kernel - Re: [PATCH] usb: chipidea: msm: ci_hdrc_msm_probe() missing of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170719015147.GA26218@b29397-desktop>
Date:   Wed, 19 Jul 2017 09:51:48 +0800
From:   Peter Chen <hzpeterchen@...il.com>
To:     <frowand.list@...il.com>
CC:     Peter Chen <Peter.Chen@....com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        <linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <stable@...r.kernel.org>
Subject: Re: [PATCH] usb: chipidea: msm: ci_hdrc_msm_probe() missing
 of_node_get()

On Tue, Jul 18, 2017 at 04:31:28PM -0700, frowand.list@...il.com wrote:
> From: Frank Rowand <frank.rowand@...y.com>
> 
> Boot fails for qcom-apq8074-dragonboard on 4.13-rc1 with error:
> OF: ERROR: Bad of_node_put() on /soc/usb@...55000
> 
> The error will occur if the configuration is set to:
>    CONFIG_OF_OVERLAY y
>    CONFIG_OF_UNITTEST y
>    CONFIG_OF_DYNAMIC y
>    CONFIG_OF_RESOLVE y
> 
> If CONFIG_OF_DYNAMIC is enabled then of_node_release() detects an
> attempt to release a node that is still attached to the device tree.
> 
> Signed-off-by: Frank Rowand <frank.rowand@...y.com>
> ---
>  drivers/usb/chipidea/ci_hdrc_msm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/chipidea/ci_hdrc_msm.c b/drivers/usb/chipidea/ci_hdrc_msm.c
> index 0bdfcdcbf7a5..bb626120296f 100644
> --- a/drivers/usb/chipidea/ci_hdrc_msm.c
> +++ b/drivers/usb/chipidea/ci_hdrc_msm.c
> @@ -251,7 +251,7 @@ static int ci_hdrc_msm_probe(struct platform_device *pdev)
>  	if (ret)
>  		goto err_mux;
>  
> -	ulpi_node = of_find_node_by_name(pdev->dev.of_node, "ulpi");
> +	ulpi_node = of_find_node_by_name(of_node_get(pdev->dev.of_node), "ulpi");
>  	if (ulpi_node) {
>  		phy_node = of_get_next_available_child(ulpi_node, NULL);
>  		ci->hsic = of_device_is_compatible(phy_node, "qcom,usb-hsic-phy");
> -- 

Applied, thanks.

-- 

Best Regards,
Peter Chen