[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1500467788.25934.37.camel@perches.com>
Date: Wed, 19 Jul 2017 05:36:28 -0700
From: Joe Perches <joe@...ches.com>
To: Jaya Durga <rjdurga@...il.com>, gregkh@...uxfoundation.org
Cc: lars@...afoo.de, Michael.Hennerich@...log.com, jic23@...nel.org,
knaack.h@....de, pmeerw@...erw.net, linux-iio@...r.kernel.org,
devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/3] Staging: speakup: speakup_keypc.c: usleep_range
is preferred over udelay
On Wed, 2017-07-19 at 17:55 +0530, Jaya Durga wrote:
> Fix checkpatch issue: CHECK: usleep_range is preferred over udelay;
[]
> diff --git a/drivers/staging/speakup/speakup_keypc.c b/drivers/staging/speakup/speakup_keypc.c
[]
> @@ -28,7 +28,7 @@
>
> #define DRV_VERSION "2.10"
> #define SYNTH_IO_EXTENT 0x04
> -#define SWAIT udelay(70)
> +#define SWAIT usleep_range(70, 150)
It'd probably be more sensible to remove this define as
SWAIT is used just once and use usleep_range directly.
Powered by blists - more mailing lists