linux-kernel - Re: [PATCH v6 1/3] clk: nxp: clk-lpc32xx: rename clk_gate_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <63be565e-4f3c-725c-c31b-a333b9bde89d@st.com>
Date:   Wed, 19 Jul 2017 12:50:01 +0000
From:   Gabriel FERNANDEZ <gabriel.fernandez@...com>
To:     Vladimir Zapolskiy <vz@...ia.com>,
        Alexandre TORGUE <alexandre.torgue@...com>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...eaurora.org>
CC:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Russell King <linux@...linux.org.uk>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Nicolas Pitre <nico@...aro.org>, Arnd Bergmann <arnd@...db.de>,
        "daniel.thompson@...aro.org" <daniel.thompson@...aro.org>,
        "andrea.merello@...il.com" <andrea.merello@...il.com>,
        "radoslaw.pietrzyk@...il.com" <radoslaw.pietrzyk@...il.com>,
        Lee Jones <lee.jones@...aro.org>,
        Sylvain Lemieux <slemieux.tyco@...il.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>,
        Ludovic BARRE <ludovic.barre@...com>,
        "Olivier BIDEAU" <olivier.bideau@...com>,
        Amelie DELAUNAY <amelie.delaunay@...com>,
        "gabriel.fernandez.st@...il.com" <gabriel.fernandez.st@...il.com>,
        "Arvind Yadav" <arvind.yadav.cs@...il.com>
Subject: Re: [PATCH v6 1/3] clk: nxp: clk-lpc32xx: rename
 clk_gate_is_enabled()

Hi Vladimir,

Many thanks for the code review.


On 07/18/2017 09:48 PM, Vladimir Zapolskiy wrote:
> Hello Gabriel,
>
> On 07/18/2017 10:53 AM, gabriel.fernandez@...com wrote:
>> From: Gabriel Fernandez <gabriel.fernandez@...com>
>>
>> We need to export clk_gate_is_enabled() from clk framework, then
> first of all let's clarify if you really need to export clk_gate_is_enabled()
> from the CCF.
Yes i really need to export clk_gate_is_enabled()

>> to avoid compilation issue we have to rename clk_gate_is_enabled()
>> in NXP LPC32xx clock driver.
>>
>> Signed-off-by: Gabriel Fernandez <gabriel.fernandez@...com>
>> ---
>>   drivers/clk/nxp/clk-lpc32xx.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/clk/nxp/clk-lpc32xx.c b/drivers/clk/nxp/clk-lpc32xx.c
>> index 5b98ff9..1cc71ad 100644
>> --- a/drivers/clk/nxp/clk-lpc32xx.c
>> +++ b/drivers/clk/nxp/clk-lpc32xx.c
>> @@ -903,7 +903,7 @@ static void clk_gate_disable(struct clk_hw *hw)
>>   	regmap_update_bits(clk_regmap, clk->reg, mask, val);
>>   }
>>   
>> -static int clk_gate_is_enabled(struct clk_hw *hw)
>> +static int __clk_gate_is_enabled(struct clk_hw *hw)
>>   {
>>   	struct lpc32xx_clk_gate *clk = to_lpc32xx_gate(hw);
>>   	u32 val;
>> @@ -918,7 +918,7 @@ static int clk_gate_is_enabled(struct clk_hw *hw)
>>   static const struct clk_ops lpc32xx_clk_gate_ops = {
>>   	.enable = clk_gate_enable,
>>   	.disable = clk_gate_disable,
>> -	.is_enabled = clk_gate_is_enabled,
>> +	.is_enabled = __clk_gate_is_enabled,
> In case if this change gets continuation, here I want to see the same
> prefixes for all functions and no underscores, namely it shall be
> * lpc32xx_clk_gate_enable(),
> * lpc32xx_clk_gate_disable(),
> * lpc32xx_clk_gate_is_enabled().
ok il will use same prefixes for all functions

Best regards

Gabriel.

>>   };
>>   
>>   #define div_mask(width)	((1 << (width)) - 1)
>>
> --
> With best wishes,
> Vladimir