linux-kernel - RE: [PATCH v2 2/2] RDMA/core: Initialize port_num in qp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5C5647B5F4794941BAAC07CF28785CBC33E5F3B1@fmsmsx101.amr.corp.intel.com>
Date:   Wed, 19 Jul 2017 14:38:18 +0000
From:   "Ismail, Mustafa" <mustafa.ismail@...el.com>
To:     "Kalderon, Michal" <Michal.Kalderon@...ium.com>,
        "Marciniszyn, Mike" <mike.marciniszyn@...el.com>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "dledford@...hat.com" <dledford@...hat.com>
CC:     "swise@...ngridcomputing.com" <swise@...ngridcomputing.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        "e1000-rdma@...ts.sourceforge.net" <e1000-rdma@...ts.sourceforge.net>,
        "Saleem, Shiraz" <shiraz.saleem@...el.com>,
        "Amrani, Ram" <Ram.Amrani@...ium.com>
Subject: RE: [PATCH v2 2/2] RDMA/core: Initialize port_num in qp_attr

> -----Original Message-----
> From: Kalderon, Michal [mailto:Michal.Kalderon@...ium.com]
> Sent: Wednesday, July 19, 2017 3:10 AM
> To: Marciniszyn, Mike <mike.marciniszyn@...el.com>; Ismail, Mustafa
> <mustafa.ismail@...el.com>; linux-rdma@...r.kernel.org;
> dledford@...hat.com
> Cc: swise@...ngridcomputing.com; linux-kernel@...r.kernel.org;
> stable@...r.kernel.org; e1000-rdma@...ts.sourceforge.net; Saleem, Shiraz
> <shiraz.saleem@...el.com>; Amrani, Ram <Ram.Amrani@...ium.com>
> Subject: RE: [PATCH v2 2/2] RDMA/core: Initialize port_num in qp_attr
> 
> > From: linux-rdma-owner@...r.kernel.org [mailto:linux-rdma-
> > owner@...r.kernel.org] On Behalf Of Marciniszyn, Mike
> > > Initialize the port_num for iWARP in rdma_init_qp_attr.
> > >
> > > Fixes: 5ecce4c9b17b("Check port number supplied by user verbs cmds")
> > > Cc: <stable@...r.kernel.org> # v2.6.14+
> > > Reviewed-by: Steve Wise <swise@...ngridcomputing.com>
> > > Signed-off-by: Mustafa Ismail <mustafa.ismail@...el.com>
> >
> Why is the second patch required if you only validate the port_num if the
> IB_QP_PORT mask is on?
> Given the first patch [PATCH v2 1/2] RDMA/uverbs: Fix the check for port
> number, this one seems redundant.
Strictly speaking it is not required, but we felt it safer to always return a valid port number
as is done in the IB case.

Regards,

Mustafa