linux-kernel - Re: [PATCH v4 01/14] spi: qup: Enable chip select support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 20 Jul 2017 09:03:13 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Varadarajan Narayanan <varada@...eaurora.org>
Cc:     Mark Brown <broonie@...nel.org>, Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Andy Gross <andy.gross@...aro.org>,
        David Brown <david.brown@...aro.org>,
        linux-spi <linux-spi@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
        "open list:ARM/QUALCOMM SUPPORT" <linux-soc@...r.kernel.org>,
        Sham Muthayyan <smuthayy@...eaurora.org>
Subject: Re: [PATCH v4 01/14] spi: qup: Enable chip select support

Hi Varadarajan,

On Tue, Jun 27, 2017 at 11:45 AM, Varadarajan Narayanan
<varada@...eaurora.org> wrote:
> Enable chip select support for QUP versions later than v1.
> The chip select support was broken in QUP version 1. Hence
> the chip select support was removed earlier in commit
> 4a8573abe965115bc5b064401fd669b74e985258. Since the chip
> select support is functional in recent versions of QUP,
> re-enabling it for QUP versions later than v1.
>
> Signed-off-by: Sham Muthayyan <smuthayy@...eaurora.org>
> Signed-off-by: Varadarajan Narayanan <varada@...eaurora.org>

> --- a/drivers/spi/spi-qup.c
> +++ b/drivers/spi/spi-qup.c

> @@ -846,6 +864,9 @@ static int spi_qup_probe(struct platform_device *pdev)
>         if (of_device_is_compatible(dev->of_node, "qcom,spi-qup-v1.1.1"))
>                 controller->qup_v1 = 1;

I know it was not introduced by your patch, but the proper way is to obtain
the version flag from spi_qup_dt_match[].data.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds