linux-kernel - Re: [PATCH 1/3] uuid: fix incorrect uuid_equal conversion in test_uuid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOQ4uxjMNsSNKosvkcvKdBWqQqd7r-CDV5kghOx7mh4o0GkFZw@mail.gmail.com>
Date:   Thu, 20 Jul 2017 11:59:01 +0300
From:   Amir Goldstein <amir73il@...il.com>
To:     Christoph Hellwig <hch@....de>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Andreas Noever <andreas.noever@...il.com>,
        Michael Jamet <michael.jamet@...el.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Yehezkel Bernat <yehezkel.bernat@...el.com>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] uuid: fix incorrect uuid_equal conversion in test_uuid_test

On Thu, Jul 20, 2017 at 10:56 AM, Christoph Hellwig <hch@....de> wrote:
> Fixes: df33767d ("uuid: hoist helpers uuid_equal() and uuid_copy() from xfs")
> Reported-by: kernel test robot <xiaolong.ye@...el.com>
> Signed-off-by: Christoph Hellwig <hch@....de>

Oops
Reviewed-by: Amir Goldstein <amir73il@...il.com>


> ---
>  lib/test_uuid.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/test_uuid.c b/lib/test_uuid.c
> index 478c049630b5..cd819c397dc7 100644
> --- a/lib/test_uuid.c
> +++ b/lib/test_uuid.c
> @@ -82,7 +82,7 @@ static void __init test_uuid_test(const struct test_uuid_data *data)
>                 test_uuid_failed("conversion", false, true, data->uuid, NULL);
>
>         total_tests++;
> -       if (uuid_equal(&data->be, &be)) {
> +       if (!uuid_equal(&data->be, &be)) {
>                 sprintf(buf, "%pUb", &be);
>                 test_uuid_failed("cmp", false, true, data->uuid, buf);
>         }
> --
> 2.11.0
>