linux-kernel - Re: [PATCH 1/3] can: m

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <11cb765b-d69a-d7d5-b1e4-b55200764e63@cogentembedded.com>
Date:   Thu, 20 Jul 2017 12:42:33 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Franklin S Cooper Jr <fcooper@...com>,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        netdev@...r.kernel.org, linux-can@...r.kernel.org,
        wg@...ndegger.com, mkl@...gutronix.de, robh+dt@...nel.org,
        quentin.schulz@...e-electrons.com
Subject: Re: [PATCH 1/3] can: m_can: Make hclk optional

Hello!

On 7/20/2017 2:09 AM, Franklin S Cooper Jr wrote:

> Hclk is the MCAN's interface clock. However, for OMAP based devices such as
> DRA7 SoC family the interface clock is handled by hwmod. Therefore, this
> interface clock is managed by hwmod driver via pm_runtime_get and
> pm_runtime_put calls. Therefore, this interface clock isn't defined in DT
> and thus the driver shouldn't fail if this clock isn't found.
> 
> Signed-off-by: Franklin S Cooper Jr <fcooper@...com>
> ---
>   drivers/net/can/m_can/m_can.c | 9 +++++++--
>   1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c
> index f4947a7..7fe9145 100644
> --- a/drivers/net/can/m_can/m_can.c
> +++ b/drivers/net/can/m_can/m_can.c
> @@ -1568,8 +1568,13 @@ static int m_can_plat_probe(struct platform_device *pdev)
>   	hclk = devm_clk_get(&pdev->dev, "hclk");
>   	cclk = devm_clk_get(&pdev->dev, "cclk");
>   
> -	if (IS_ERR(hclk) || IS_ERR(cclk)) {
> -		dev_err(&pdev->dev, "no clock found\n");
> +	if (IS_ERR(hclk)) {
> +		dev_warn(&pdev->dev, "can't find hclk\n");
> +		hclk = 0;

    s/0/NULL/.

[...]

MBR, Sergei