linux-kernel - [tip:x86/mm] x86/boot: Fix memremap() related build failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 20 Jul 2017 03:27:24 -0700
From:   tip-bot for Ingo Molnar <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     tglx@...utronix.de, mingo@...nel.org,
        torvalds@...ux-foundation.org, peterz@...radead.org,
        linux-kernel@...r.kernel.org, hpa@...or.com
Subject: [tip:x86/mm] x86/boot: Fix memremap() related build failure

Commit-ID:  693bf0aa01b7f9a1b24b2b932d555c6667f17a1a
Gitweb:     http://git.kernel.org/tip/693bf0aa01b7f9a1b24b2b932d555c6667f17a1a
Author:     Ingo Molnar <mingo@...nel.org>
AuthorDate: Thu, 20 Jul 2017 11:23:07 +0200
Committer:  Ingo Molnar <mingo@...nel.org>
CommitDate: Thu, 20 Jul 2017 11:37:58 +0200

x86/boot: Fix memremap() related build failure

The following commit:

  5997efb96756 ("x86/boot: Use memremap() to map the MPF and MPC data")

causes new build failures on certain randconfigs:

  drivers/sfi/sfi_core.c: In function ‘sfi_map_memory’:
  drivers/sfi/sfi_core.c:104:10: error: implicit declaration of function ‘memremap’ [-Werror=implicit-function-declaration]
  drivers/sfi/sfi_core.c:104:31: error: ‘MEMREMAP_WB’ undeclared (first use in this function)

This is a case of parasitic header dependencies: the sfi_core.c file indirectly
includes <linux/io.h> for typical - but not all configs.

Including <linux/io.h> explicitly solves the build failure.

Cc: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Peter Zijlstra <peterz@...radead.org>
Cc: Thomas Gleixner <tglx@...utronix.de>
Cc: arnd@...db.de
Cc: aryabinin@...tuozzo.com
Cc: bp@...en8.de
Cc: bp@...e.de
Cc: brijesh.singh@....com
Cc: corbet@....net
Cc: dvyukov@...gle.com
Cc: dyoung@...hat.com
Cc: glider@...gle.com
Cc: konrad.wilk@...cle.com
Cc: linux-tip-commits@...r.kernel.org
Cc: luto@...nel.org
Cc: lwoodman@...hat.com
Cc: matt@...eblueprint.co.uk
Cc: mst@...hat.com
Cc: pbonzini@...hat.com
Cc: riel@...hat.com
Cc: rkrcmar@...hat.com
Cc: thomas.lendacky@....com
Cc: toshi.kani@....com
Link: http://lkml.kernel.org/r/20170720092307.6xslahuaclmsiffe@gmail.com
Signed-off-by: Ingo Molnar <mingo@...nel.org>
---
 drivers/sfi/sfi_core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/sfi/sfi_core.c b/drivers/sfi/sfi_core.c
index d5ce534..153b3f3 100644
--- a/drivers/sfi/sfi_core.c
+++ b/drivers/sfi/sfi_core.c
@@ -68,6 +68,7 @@
 #include <linux/init.h>
 #include <linux/sfi.h>
 #include <linux/slab.h>
+#include <linux/io.h>
 
 #include "sfi_core.h"