linux-kernel - Re: [PATCH v5] Bluetooth: btusb: Fix memory leak in play

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <59708C48.3020500@rock-chips.com>
Date:   Thu, 20 Jul 2017 18:56:08 +0800
From:   jeffy <jeffy.chen@...k-chips.com>
To:     Oliver Neukum <oneukum@...e.com>, linux-kernel@...r.kernel.org
CC:     briannorris@...omium.org, dianders@...omium.org,
        Johan Hedberg <johan.hedberg@...il.com>,
        xiyou.wangcong@...il.com, Marcel Holtmann <marcel@...tmann.org>,
        Gustavo Padovan <gustavo@...ovan.org>,
        linux-bluetooth@...r.kernel.org
Subject: Re: [PATCH v5] Bluetooth: btusb: Fix memory leak in play_deferred

Hi Oliver,

On 07/20/2017 05:11 PM, Oliver Neukum wrote:
>> >+		if (err < 0) {
>> >+			if (err != -EPERM && err != -ENODEV)
>> >+				BT_ERR("%s urb %p submission failed (%d)",
>> >+				       data->hdev->name, urb, -err);
>> >+			kfree(urb->setup_packet);
>> >+			usb_unanchor_urb(urb);
>> >+			usb_free_urb(urb);
>> >  			break;
>> >+		}
>> >
>> >  		data->tx_in_flight++;
>> >+		usb_free_urb(urb);
>> >+	}
>> >+
>> >+	/* Cleanup the rest deferred urbs. */
>> >+	while ((urb = usb_get_from_anchor(&data->deferred))) {
>> >+		BT_ERR("%s urb %p submission failed (%d)",
> This looks very good, except for this message, which is incorrect.
>
hmm, since we already print error log when submission failed before, 
i'll remove this, thanks.