[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20170720081508.33563afe@vento.lan>
Date: Thu, 20 Jul 2017 08:15:38 -0300
From: Mauro Carvalho Chehab <mchehab@...pensource.com>
To: Rob Herring <robh@...nel.org>
Cc: Sylwester Nawrocki <s.nawrocki@...sung.com>,
Frank Rowand <frowand.list@...il.com>,
"linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
Kyungmin Park <kyungmin.park@...sung.com>,
Andrzej Hajda <a.hajda@...sung.com>,
"Lad, Prabhakar" <prabhakar.csengg@...il.com>,
Songjun Wu <songjun.wu@...rochip.com>,
Kukjin Kim <kgene@...nel.org>,
Krzysztof Kozlowski <krzk@...nel.org>,
Minghsiu Tsai <minghsiu.tsai@...iatek.com>,
Houlong Wei <houlong.wei@...iatek.com>,
Andrew-CT Chen <andrew-ct.chen@...iatek.com>,
Matthias Brugger <matthias.bgg@...il.com>,
Laurent Pinchart <laurent.pinchart@...asonboard.com>,
Niklas Söderlund
<niklas.soderlund@...natech.se>,
Guennadi Liakhovetski <g.liakhovetski@....de>,
Hyun Kwon <hyun.kwon@...inx.com>,
Michal Simek <michal.simek@...inx.com>,
Sören Brinkmann <soren.brinkmann@...inx.com>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"linux-samsung-soc@...r.kernel.org"
<linux-samsung-soc@...r.kernel.org>,
linux-mediatek@...ts.infradead.org,
"open list:MEDIA DRIVERS FOR RENESAS - FCP"
<linux-renesas-soc@...r.kernel.org>
Subject: Re: [PATCH] media: Convert to using %pOF instead of full_name
Em Wed, 19 Jul 2017 11:02:01 -0500
Rob Herring <robh@...nel.org> escreveu:
> On Wed, Jul 19, 2017 at 4:41 AM, Sylwester Nawrocki
> <s.nawrocki@...sung.com> wrote:
> > On 07/18/2017 11:43 PM, Rob Herring wrote:
> >> Now that we have a custom printf format specifier, convert users of
> >> full_name to use %pOF instead. This is preparation to remove storing
> >> of the full path string for each node.
> >>
> >> Signed-off-by: Rob Herring <robh@...nel.org>
> >
> >> ---
> >> drivers/media/i2c/s5c73m3/s5c73m3-core.c | 3 +-
> >> drivers/media/i2c/s5k5baf.c | 7 ++--
> >> drivers/media/platform/am437x/am437x-vpfe.c | 4 +-
> >> drivers/media/platform/atmel/atmel-isc.c | 4 +-
> >> drivers/media/platform/davinci/vpif_capture.c | 16 ++++----
> >> drivers/media/platform/exynos4-is/fimc-is.c | 8 ++--
> >> drivers/media/platform/exynos4-is/fimc-lite.c | 3 +-
> >> drivers/media/platform/exynos4-is/media-dev.c | 8 ++--
> >> drivers/media/platform/exynos4-is/mipi-csis.c | 4 +-
> >> drivers/media/platform/mtk-mdp/mtk_mdp_comp.c | 6 +--
> >> drivers/media/platform/mtk-mdp/mtk_mdp_core.c | 8 ++--
> >> drivers/media/platform/omap3isp/isp.c | 8 ++--
> >> drivers/media/platform/pxa_camera.c | 2 +-
> >> drivers/media/platform/rcar-vin/rcar-core.c | 4 +-
> >> drivers/media/platform/soc_camera/soc_camera.c | 6 +--
> >> drivers/media/platform/xilinx/xilinx-vipp.c | 52 +++++++++++++-------------
> >> drivers/media/v4l2-core/v4l2-async.c | 4 +-
> >> drivers/media/v4l2-core/v4l2-clk.c | 3 +-
> >> include/media/v4l2-clk.h | 4 +-
> >> 19 files changed, 71 insertions(+), 83 deletions(-)
> >
> >> diff --git a/drivers/media/platform/xilinx/xilinx-vipp.c b/drivers/media/platform/xilinx/xilinx-vipp.c
> >> index ac4704388920..9233ad0b1b6b 100644
> >> --- a/drivers/media/platform/xilinx/xilinx-vipp.c
> >> +++ b/drivers/media/platform/xilinx/xilinx-vipp.c
> >
> >> @@ -144,9 +144,8 @@ static int xvip_graph_build_one(struct xvip_composite_device *xdev,
> >> remote = ent->entity;
> >>
> >> if (link.remote_port >= remote->num_pads) {
> >> - dev_err(xdev->dev, "invalid port number %u on %s\n",
> >> - link.remote_port,
> >> - to_of_node(link.remote_node)->full_name);
> >> + dev_err(xdev->dev, "invalid port number %u on %pOF\n",
> >> + link.remote_port, link.remote_node);
> >
> > Shouldn't there be to_of_node(link.remote_node) instead of link.remote_node ?
>
> Humm, yes. I thought I fixed that.
After such fix, I'm OK with this patch.
Are you planning to apply it on your tree, or via the media one?
I guess it is probably better to apply via media, in order to avoid
conflicts with other changes.
Thanks,
Mauro
Powered by blists - more mailing lists