linux-kernel - Re: [PATCH] tracing: Fix kmemleak in instance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170720092156.6b77b64b@gandalf.local.home>
Date:   Thu, 20 Jul 2017 09:21:56 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Chunyu Hu <chuhu@...hat.com>
Cc:     linux-kernel@...r.kernel.org, mingo@...nel.org,
        mhiramat@...nel.org, shuwang@...hat.com, liwang@...hat.com
Subject: Re: [PATCH] tracing: Fix kmemleak in instance_rmdir

On Thu, 20 Jul 2017 18:36:09 +0800
Chunyu Hu <chuhu@...hat.com> wrote:

> Hit the kmemleak when executing instance_rmdir, it forgot releasing
> mem of tracing_cpumask. With this fix, the warn does not appear any
> more.

Thanks, applied!

-- Steve

> 
> unreferenced object 0xffff93a8dfaa7c18 (size 8):
>   comm "mkdir", pid 1436, jiffies 4294763622 (age 9134.308s)
>   hex dump (first 8 bytes):
>     ff ff ff ff ff ff ff ff                          ........
>   backtrace:
>     [<ffffffff88b6567a>] kmemleak_alloc+0x4a/0xa0
>     [<ffffffff8861ea41>] __kmalloc_node+0xf1/0x280
>     [<ffffffff88b505d3>] alloc_cpumask_var_node+0x23/0x30
>     [<ffffffff88b5060e>] alloc_cpumask_var+0xe/0x10
>     [<ffffffff88571ab0>] instance_mkdir+0x90/0x240
>     [<ffffffff886e5100>] tracefs_syscall_mkdir+0x40/0x70
>     [<ffffffff886565c9>] vfs_mkdir+0x109/0x1b0
>     [<ffffffff8865b1d0>] SyS_mkdir+0xd0/0x100
>     [<ffffffff88403857>] do_syscall_64+0x67/0x150
>     [<ffffffff88b710e7>] return_from_SYSCALL_64+0x0/0x6a
>     [<ffffffffffffffff>] 0xffffffffffffffff
> 
> Signed-off-by: Chunyu Hu <chuhu@...hat.com>
> ---
>  kernel/trace/trace.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index 2d0ffcc..42b9355 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -7774,6 +7774,7 @@ static int instance_rmdir(const char *name)
>  	}
>  	kfree(tr->topts);
>  
> +	free_cpumask_var(tr->tracing_cpumask);
>  	kfree(tr->name);
>  	kfree(tr);
>