linux-kernel - Re: [PATCH RESEND] HID: wacom: Remove comparison of u8 mode with zero and simplify.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 20 Jul 2017 15:43:36 +0200 (CEST)
From:   Jiri Kosina <jikos@...nel.org>
To:     Christos Gkekas <chris.gekas@...il.com>
cc:     Joe Perches <joe@...ches.com>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND] HID: wacom: Remove comparison of u8 mode with
 zero and simplify.

On Sat, 8 Jul 2017, Christos Gkekas wrote:

> Variable mode in method wacom_show_remote_mode() is defined as u8, thus
> statement (mode >= 0) is always true and should be removed, simplifying
> the logic.
> 
> Signed-off-by: Christos Gkekas <chris.gekas@...il.com>

Applied to for-4.14/wacom, thanks.

-- 
Jiri Kosina
SUSE Labs