linux-kernel - Re: [alsa-devel] [PATCH v3] ASoC: sgtl5000: add avc support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f499e55f-498b-9954-b3dc-52f704cecd7a@g0hl1n.net>
Date:   Thu, 20 Jul 2017 19:38:56 +0200
From:   Richard Leitner <dev@...l1n.net>
To:     Fabio Estevam <festevam@...il.com>,
        Richard Leitner <dev@...l1n.net>
Cc:     Richard Leitner <richard.leitner@...data.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Clemens Gruber <clemens.gruber@...ruber.com>,
        kalle.kankare@...cit.fi, Eric Nelson <eric@...int.com>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Fabio Estevam <fabio.estevam@....com>
Subject: Re: [alsa-devel] [PATCH v3] ASoC: sgtl5000: add avc support


On 07/20/2017 07:27 PM, Fabio Estevam wrote:
> Hi Richard,
>
> On Thu, Jul 20, 2017 at 2:25 PM, Richard Leitner <dev@...l1n.net> wrote:
>
>> Does this occur only on reboot or everytime the driver tries to read the AVC
>> threshold (avc_get_threshold)?
>> Are you able to set the AVC threshold (using amixer)?
>
> I am not even using the codec. I just run 'reboot' and the problem happens.
>
> The following change fixes the 'reboot' issue for me. Could you please try it?
>
> --- a/sound/soc/codecs/sgtl5000.c
> +++ b/sound/soc/codecs/sgtl5000.c
> @@ -409,7 +409,7 @@ static int dac_put_volsw(struct snd_kcontrol *kcontrol,
>  static int avc_get_threshold(struct snd_kcontrol *kcontrol,
>                              struct snd_ctl_elem_value *ucontrol)
>  {
> -       struct snd_soc_codec *codec = snd_kcontrol_chip(kcontrol);
> +       struct snd_soc_codec *codec = snd_soc_kcontrol_codec(kcontrol);

Thank you for spotting this! That works of course.

I'm sorry, it seems I messed something up during copy/paste for my own 
backport version of this patch. Seems like I tested and sent a different 
version of the patch... That definitely shouldn't have happened :-(

Do you want to send that patch or should I?

Thank you again Fabio!

regards,
Richard.L