linux-kernel - Re: [PATCH 4/4] time: rtc-lib: Add CONFIG_RTC_SHOW_TIME

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d3dce8d2-145a-d4ff-39cc-3b11e59ec921@android.com>
Date:   Thu, 20 Jul 2017 10:52:39 -0700
From:   Mark Salyzyn <salyzyn@...roid.com>
To:     Pavel Machek <pavel@....cz>
Cc:     linux-kernel@...r.kernel.org, rjw@...ysocki.net,
        len.brown@...el.com, linux-pm@...r.kernel.org,
        a.zummo@...ertech.it, alexandre.belloni@...e-electrons.com,
        linux-rtc@...r.kernel.org, prarit@...hat.com,
        andy.shevchenko@...il.com,
        "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
Subject: Re: [PATCH 4/4] time: rtc-lib: Add CONFIG_RTC_SHOW_TIME_RTC

On 07/20/2017 01:26 AM, Pavel Machek wrote:
>> +#if defined(CONFIG_RTC_SHOW_TIME_RTC)
>> +	{
>> +		struct rtc_time tm;
>> +
>> +		rtc_time64_to_tm(ts.tv_sec, &tm);
>> +		pr_info("%s %d-%02d-%02d %02d:%02d:%02d.%09lu UTC\n",
>> +			prefix_msg ? prefix_msg : "Time:",
>> +			tm.tm_year + 1900, tm.tm_mon + 1, tm.tm_mday,
>> +			tm.tm_hour, tm.tm_min, tm.tm_sec, ts.tv_nsec);
>> +	}
>> +#else
>
> This was NAKed before. Are you even listening, or are you trying to
> flood us with enough mail so that someone applies your patches by
> mistake?
> 									Pavel

It was NAKed in the group, I put it aside in its own patch to keep from 
throwing out the baby with the bathwater. Was hoping that a private 
CONFIG_RTC_SHOW_TIME_RTC would be acceptable.

I guess not, topic is dead. A refresh is being tested that addresses 
many of the other concerns.

-- Mark