linux-kernel - Re: [PATCH v3 3/3] nvme: wwid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170720201140.GE1202@localhost.localdomain>
Date:   Thu, 20 Jul 2017 16:11:40 -0400
From:   Keith Busch <keith.busch@...el.com>
To:     Martin Wilck <mwilck@...e.com>
Cc:     Christoph Hellwig <hch@....de>, Sagi Grimberg <sagi@...mberg.me>,
        Martin Wilck <mwilck@...e.de>,
        Johannes Thumshirn <jthumshirn@...e.de>,
        Hannes Reinecke <hare@...e.de>, linux-nvme@...ts.infradead.org,
        linux-kernel@...r.kernel.org, joe@...ches.com
Subject: Re: [PATCH v3 3/3] nvme: wwid_show: strip trailing 0-bytes

On Thu, Jul 20, 2017 at 06:34:02PM +0200, Martin Wilck wrote:
> Some broken targets (such as the current Linux target) pad
> model or serial fields with 0-bytes rather than spaces. The
> NVME spec disallows 0 bytes in "ASCII" fields.
> Thus strip trailing 0-bytes, too. Also make sure that we get no
> underflow for pathological input.
> 
> Signed-off-by: Martin Wilck <mwilck@...e.com>
> Reviewed-by: Hannes Reinecke <hare@...e.de>
> Acked-by: Christoph Hellwig <hch@....de>

Looks good.

Reviewed-by: Keith Busch <keith.busch@...el.com>