linux-kernel - Re: [HMM 12/15] mm/migrate: new memory migration helper for use with device memory v4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d31b88e7-be7e-c1ca-513f-f12edb126eac@nvidia.com>
Date:   Thu, 20 Jul 2017 14:05:00 -0700
From:   Evgeny Baskakov <ebaskakov@...dia.com>
To:     Jerome Glisse <jglisse@...hat.com>
CC:     "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        John Hubbard <jhubbard@...dia.com>,
        David Nellans <dnellans@...dia.com>,
        Mark Hairgrove <mhairgrove@...dia.com>,
        Sherry Cheung <SCheung@...dia.com>,
        Subhash Gutti <sgutti@...dia.com>
Subject: Re: [HMM 12/15] mm/migrate: new memory migration helper for use with
 device memory v4

On 7/10/17 5:54 PM, Jerome Glisse wrote:

> On Mon, Jul 10, 2017 at 05:17:23PM -0700, Evgeny Baskakov wrote:
>> On 7/10/17 4:43 PM, Jerome Glisse wrote:
>>
>>> On Mon, Jul 10, 2017 at 03:59:37PM -0700, Evgeny Baskakov wrote:
>>> ...
>>> Horrible stupid bug in the code, most likely from cut and paste. Attached
>>> patch should fix it. I don't know how long it took for you to trigger it.
>>>
>>> Jérôme
>> Thanks, this indeed fixes the problem! Yes, it took a nightly run before it
>> triggered.
>>
>> One a side note, should this "return NULL" be replaced with "return
>> ERR_PTR(-ENOMEM)"?
> Or -EBUSY but yes sure.
>
> Jérôme

Hi Jerome,

Are these fixes in already (for the alloc_chrdev_region and "return 
NULL" issues)? I don't see them in hmm-next nor in hmm-v24.

Can you please double check it?

Thanks!

-- 
Evgeny Baskakov
NVIDIA