linux-kernel - Re: [PATCH] dmaengine: ioatdma: Fix error handling path in 'ioat_dma_self

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170721063116.GK3053@localhost>
Date:   Fri, 21 Jul 2017 12:01:17 +0530
From:   Vinod Koul <vinod.koul@...el.com>
To:     Dave Jiang <dave.jiang@...el.com>
Cc:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        "Williams, Dan J" <dan.j.williams@...el.com>,
        "dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] dmaengine: ioatdma: Fix error handling path in
 'ioat_dma_self_test()'

On Wed, Jul 19, 2017 at 03:21:23PM -0700, Dave Jiang wrote:
> 
> 
> On 07/19/2017 03:16 PM, Christophe JAILLET wrote:
> > If the 'memcmp' fails, free allocated resources as done in all other
> > error handling paths.
> > 
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

You meant acked right..?

> 
> Good catch! Thanks.
> 
> Signed-off-by: Dave Jiang <dave.jiang@...el.com>
> 
> > ---
> > Please review carefully, this patch looks "too obvious" to me!
> > ---
> >  drivers/dma/ioat/init.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/dma/ioat/init.c b/drivers/dma/ioat/init.c
> > index ed8ed1192775..948fc1f8fb5c 100644
> > --- a/drivers/dma/ioat/init.c
> > +++ b/drivers/dma/ioat/init.c
> > @@ -390,7 +390,7 @@ static int ioat_dma_self_test(struct ioatdma_device *ioat_dma)
> >  	if (memcmp(src, dest, IOAT_TEST_SIZE)) {
> >  		dev_err(dev, "Self-test copy failed compare, disabling\n");
> >  		err = -ENODEV;
> > -		goto free_resources;
> > +		goto unmap_dma;
> >  	}
> >  
> >  unmap_dma:
> > 

-- 
~Vinod