linux-kernel - Re: [PATCH 2/3] usb: xhci: Add DbC support in xHCI driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87pocu3wts.fsf@linux.intel.com>
Date:   Fri, 21 Jul 2017 13:31:43 +0300
From:   Felipe Balbi <felipe.balbi@...ux.intel.com>
To:     Lu Baolu <baolu.lu@...ux.intel.com>,
        Mathias Nyman <mathias.nyman@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        Lu Baolu <baolu.lu@...ux.intel.com>
Subject: Re: [PATCH 2/3] usb: xhci: Add DbC support in xHCI driver


Hi,

Lu Baolu <baolu.lu@...ux.intel.com> writes:
> +static void xhci_dbc_stop(struct xhci_hcd *xhci)
> +{
> +	struct xhci_dbc		*dbc = xhci->dbc;
> +
> +	WARN_ON(!dbc);
> +
> +	cancel_delayed_work_sync(&dbc->event_work);
> +
> +	if (dbc->gs_port_num != GSPORT_INVAL) {
> +		gserial_disconnect(&dbc->gs_port);
> +		gserial_free_line(dbc->gs_port_num);

why are you tying host stack to the gadget framework?

With this, you're forcing every single PC in the world to compile the
gadget framework, that's a bit much don't you think?

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)